Fixed Microsoft.ReactNative build in VS 16.6.0

[vmoroz]

The build in VS 16.6.0 is failing with linker errors that debug database is corrupted.
This PR has a temporary workaround where we replace the /ZI flag with /Zi that fixes the build.
We can rollback this change later when VS is fixed.
But for now this PR could unblock us to use the new VS version.

Microsoft Reviewers: Open in CodeFlow

[JunielKatarn]

Note, we should probably stick to 16.5 for local development until the Azure hosts start using 16.6.
In general, I think we should try to be in sync with the CI environment which ultimately produces the release binaries.

[vmoroz]

It is probably a good idea, but I usually had no issue updating VS and was surprised with the sudden build break. I just did not want to rollback to the previous version. This is a simple change that only affects format of PDB files created at compile time. The final PDB file created by linker is the same as before.

---

In reply to: 631869556 [](ancestors = 631869556)

[ghost]

Hello @vmoroz!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 9 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[asklar]

It is probably a good idea, but I usually had no issue updating VS and was surprised with the sudden build break. I just did not want to rollback to the previous version. This is a simple change that only affects format of PDB files created at compile time. The final PDB file created by linker is the same as before.

In reply to: 631869556 [](ancestors = 631869556)

normally I'd agree but our customers will be on whatever version of VS they happen to be so I think it's good to be at the vanguard so we hit the issues before they do and we can fix them proactively.

This is a linker bug, I worked with the MSVC linker dev tonight and he has a fix. We're going to try to get this serviced down to the 16.6 release. In the meantime I have a copy of the fixed binaries on a network share in corpnet, ping me on Teams if you need access.

[NickGerleman]

Just backported to 0.62. Will soon bulk change "Backport to 0.62" to "Backported to 0.62 to label this as being backported".

[NickGerleman]

Removing "Backport to 0.61" since we're about to rename it to "Backported to 0.61" as part of backporting label migration. Leaving "Backport Approved" to track outstanding work. Already backported to 0.62, so keeping that label.

[NickGerleman]

Actually, this is one that I looked at where we didn't think we needed it for 0.61 bc we are using an older compiler toolchain in that branch. We backported to 0.62, so don't think there is active work for this item.