Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASK] The docstring explanation for LibffmConverter #1670

Closed
Tony-Feng opened this issue Mar 11, 2022 · 2 comments
Closed

[ASK] The docstring explanation for LibffmConverter #1670

Tony-Feng opened this issue Mar 11, 2022 · 2 comments
Labels
help wanted Need help from developers

Comments

@Tony-Feng
Copy link
Contributor

Description

Hello Dev Team,

In the docstring of LibffmConverter:
https://github.com/microsoft/recommenders/blob/fe215e9babf8f7caba025a83059445362cff0006/recommenders/datasets/pandas_df_utils.py#L112

I'm wondering if this line would be the following one instead:

i.e. `<field_index>:<field_feature_index>:1` or `<field_index>:<field_feature_index>:<field_feature_value>`

Since according to:
https://github.com/microsoft/recommenders/blob/fe215e9babf8f7caba025a83059445362cff0006/recommenders/datasets/pandas_df_utils.py#L225
The returned value is in form of <field_index>:<field_feature_index>:<field_feature_value> instead of <field_index>:<field_index>:<field_feature_value>.

A PR #1669 has been made to fix this typo if applicable.

Thank you very much.

@Tony-Feng Tony-Feng added the help wanted Need help from developers label Mar 11, 2022
@Tony-Feng
Copy link
Contributor Author

Hello @miguelgfierro, thanks for reviewing the PR. I'm also wondering if there would be a specific reason for selecting 1 in <field_index>:<field_feature_index>:1 for strings? Thanks again!

@miguelgfierro
Copy link
Collaborator

That's just an example, you can add the value you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need help from developers
Projects
None yet
Development

No branches or pull requests

2 participants