Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the docstring of LibffmConverter #1669

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix the docstring of LibffmConverter #1669

merged 1 commit into from
Mar 11, 2022

Conversation

Tony-Feng
Copy link
Contributor

@Tony-Feng Tony-Feng commented Mar 11, 2022 •
edited
Loading

Description

This PR aims to fix the typo mentioned in [ASK] The docstring explanation for LibffmConverter. The corresponding docstring in LibffmConverter class was changed.

Related Issues

[ASK] The docstring explanation for LibffmConverter

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@Tony-Feng Tony-Feng mentioned this pull request Mar 11, 2022
Closed
miguelgfierro
miguelgfierro approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@miguelgfierro miguelgfierro merged commit 7399d5f into recommenders-team:staging Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tony-Feng @miguelgfierro