Java bindings #147
Merged
Java bindings #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakrish
reviewed
Feb 18, 2024
|
|
||
| and run it with: | ||
| ```shell | ||
| $ java -cp target/regorus-java-0.0.1.jar:target/regorus-java-0.0.1-osx-aarch_64.jar Test.java |
There was a problem hiding this comment.
For my own understanding, can java not figure out the osx-aarch_64.jar portion automatically?
There was a problem hiding this comment.
I think not, it should be in the classpath somehow. I'm also not a Java expert and unsure if that's the optimal structure. Ideally, we should just have one fat JAR that contains everything but I'll need to research a bit and find the optimal structure. I'll work on it in the follow-up PRs.
anakrish
approved these changes
Feb 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #126.
Java bindings for Regorus using jni-rs. I adapted some build scripts from OpenDAL's Java bindings.
I'll send follow-up PRs to set up publishing to Maven Central.