Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve errors location #23

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

eric-therond
Copy link
Contributor

  • use of the span.error() function to have a better location of errors
  • except for "internal errors" when the end-user is not responsible / can't do anything with the error?

Signed-off-by: eric-therond <eric.therond.fr@gmail.com>
Copy link
Collaborator

@anakrish anakrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakrish
Copy link
Collaborator

@eric-therond
Can you fix this error?

error: this if branch is empty
--> src/interpreter.rs:552:25
|
552 | if raise_error {}
| ^^^^^^^^^^^^^^^^^ help: you can remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_if
= note: -D clippy::needless-if implied by -D warnings

@anakrish anakrish merged commit 2ba718b into microsoft:main Sep 27, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants