Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bindings and add CI tests #247

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

anakrish
Copy link
Collaborator

@anakrish anakrish commented May 21, 2024

closes #242

Also does some related cleanup. The PR workflow is split into separate workflows.

@anakrish anakrish force-pushed the update-bindings branch 7 times, most recently from 7ea4229 to 40de868 Compare May 21, 2024 04:35
Copy link

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

.github/workflows/test-python.yml Outdated Show resolved Hide resolved
@anakrish anakrish force-pushed the update-bindings branch 8 times, most recently from 4fc55c2 to 424a1ab Compare May 21, 2024 18:50
Also update version numbers of binding Rust projects to match Regorus

Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
Copy link
Contributor

@thedavemarshall thedavemarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anakrish This is awesome!

bindings/ruby/ext/regorusrb/Cargo.toml Show resolved Hide resolved
Copy link

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anakrish anakrish merged commit 9894f00 into microsoft:main May 22, 2024
14 checks passed
@anakrish anakrish deleted the update-bindings branch May 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and test bindings in CI
3 participants