rename method from Clone to clone inEngine class to match the java naming convention and definition in the java.lang.Object. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…java naming convention and definiont in the of java.lang.Object.
|
@balcanuc Thanks for the contribution. Can you rebase to the latest main to unblock testing this PR? |
|
Merging this since the blocking clippy issue already fixed in main and the rebased pr passes locally. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename method from
ClonetocloneinEngineclass to match the java naming convention and definition in thejava.lang.Object.An alternative would be to mark the current
Cloneas@Deprecatedand add a new methodclone. As the fails happens on compile time and Regorus is not at a peak adoption, I think that just renaming the method is better.