-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement most of the builtin time
module
#82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We'd need to include licenses as appropriate.
src/builtins/time.rs
Outdated
.into()) | ||
} | ||
|
||
// Adapted from the official Go implementation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function can be moved to a separate file that lists the original license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to address it with 56b3c72, but I am not sure if that's sufficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that is good for now.
Later, we might have to declare a THIRD_PARTY_NOTICES file like https://github.com/openenclave/openenclave/blob/master/THIRD_PARTY_NOTICES
or find a way to avoid the code.
754da53
to
56b3c72
Compare
Partly addresses #72.
With this PR we still fail to pass some OPA tests:
They fail because we can't parse Go's duration (
1m32s
) and time layout (2006-01-02T15:04:05.999999999Z07:00
) at the moment.I plan to address them in a follow-up PR.