Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github action doc build no longer works #428

Closed
Tratcher opened this issue Sep 18, 2020 · 4 comments · Fixed by #570
Closed

Github action doc build no longer works #428

Tratcher opened this issue Sep 18, 2020 · 4 comments · Fixed by #570
Assignees
@Tratcher
Labels
Type: Infrastructure Infrastructure work that does not affect the actual shipping code
Milestone
YARP 1.0.0-preview8

Comments

@Tratcher
Copy link
Member

https://github.com/microsoft/reverse-proxy/runs/1135982884?check_suite_focus=true

We updated to the Preview8 SDK which requires VS 16.8.0-preview2, but the github agents only have 16.7.
https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#visual-studio-enterprise-2019

For preview 5 we should probably run the steps manually, after we get all the preview5 edits made.
https://github.com/microsoft/reverse-proxy/actions/runs/261817348/workflow

@MihaZupan
@Tratcher Tratcher added the Type: Bug Something isn't working label Sep 18, 2020
@Tratcher
Copy link
Member Author

A workaround might be to revert the SDK only in that release/docs branch, but that might complicate our branching even more.

@Tratcher Tratcher mentioned this issue Sep 20, 2020
Merged
@Tratcher
Copy link
Member Author

This was worked around by building the docs locally and checking them in. The Github Action was modified to sync the checked in docs rather than build them.

Revert after 16.8 RTMs in November and gets deployed to the github agents (when?).

@karelz karelz added Type: Infrastructure Infrastructure work that does not affect the actual shipping code and removed Type: Bug Something isn't working labels Oct 1, 2020
@karelz karelz added this to the Backlog milestone Oct 1, 2020
@karelz
Copy link
Member

karelz commented Oct 1, 2020

Triage: Wait for November - it will go away, we can manually workaround until then.

@Tratcher Tratcher mentioned this issue Oct 16, 2020
Merged
@Tratcher Tratcher self-assigned this Nov 5, 2020
@Tratcher Tratcher removed this from the Backlog milestone Nov 5, 2020
@Tratcher Tratcher mentioned this issue Nov 5, 2020
Closed
@Tratcher
Copy link
Member Author

Tratcher commented Nov 6, 2020 •
edited
Loading

ETA: Nov 16-20
actions/runner-images#1891

Update, VS 16.8 might be available on the agents just after it ships, we might not need to wait for the changes in actions/runner-images#1891.

@karelz karelz added this to the YARP 1.0.0-preview8 milestone Nov 10, 2020
Tratcher added a commit that referenced this issue Nov 13, 2020
@Tratcher
Remove pre-built docs #428
403eecd
@Tratcher Tratcher mentioned this issue Nov 13, 2020
Merged
Tratcher added a commit that referenced this issue Nov 19, 2020
@Tratcher
Remove pre-built docs #428 (#546)
b34e66a
@Tratcher Tratcher mentioned this issue Nov 23, 2020
Merged
@Tratcher Tratcher removed the Blocked label Nov 23, 2020
Tratcher added a commit that referenced this issue Nov 24, 2020
@Tratcher
Remove pre-built docs #428 (#546)
581706d
Tratcher added a commit that referenced this issue Nov 24, 2020
@Tratcher
Re-enable CI doc builds #428
78a9650
@Tratcher Tratcher mentioned this issue Nov 24, 2020
Merged
Tratcher added a commit that referenced this issue Nov 24, 2020
@Tratcher @jboelter
Fix doc CI builds (#570)
6a0cf7e 
* Fix table layout in transforms.md doc (#567)

* Remove pre-built docs #428 (#546)

* Re-enable CI doc builds #428

Co-authored-by: Joshua Boelter <joshua.boelter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tratcher Tratcher

Labels
Type: Infrastructure Infrastructure work that does not affect the actual shipping code
Projects
None yet
Milestone
YARP 1.0.0-preview8
Development

Successfully merging a pull request may close this issue.

Fix doc CI builds microsoft/reverse-proxy
3 participants
@Tratcher @karelz @MihaZupan