Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net6.0 targets #972

Merged
merged 8 commits into from
May 21, 2021
Merged

Add net6.0 targets #972

merged 8 commits into from
May 21, 2021

Conversation

MihaZupan
Copy link
Member

Blocked on dotnet/aspnetcore#32364 as some of the health check tests are hitting this.

Fixes #936

@MihaZupan MihaZupan added this to the YARP 1.0.0-preview12 milestone May 3, 2021
global.json Outdated Show resolved Hide resolved
global.json Outdated Show resolved Hide resolved
testassets/ReverseProxy.Code/ReverseProxy.Code.csproj Outdated Show resolved Hide resolved
global.json Outdated Show resolved Hide resolved
@MihaZupan MihaZupan changed the title Add net6.0 target to test projects Add net6.0 targets May 4, 2021
@MihaZupan MihaZupan force-pushed the test-net6 branch 2 times, most recently from 7d2cbe4 to 1f95ba6 Compare May 4, 2021 17:11
@MihaZupan
Copy link
Member Author

Bumped the SDK to 6.0.100-preview.5.21263.3 (lastest build off the installer repo).

Everything is now buildable and testable in 6.0, with the exception of the Auth Sample. That one is hitting the following error:

  PDB0021: Document name doesn't match any pattern in Source Link: 'd:\workspace\_work\1\s\samples\ReverseProxy.Auth.Sample\Views\Account\AccessDenied.cshtml'
  PDB0021: Document name doesn't match any pattern in Source Link: 'd:\workspace\_work\1\s\samples\ReverseProxy.Auth.Sample\Views\Account\LoggedOut.cshtml'
  PDB0021: Document name doesn't match any pattern in Source Link: 'd:\workspace\_work\1\s\samples\ReverseProxy.Auth.Sample\Views\Account\Login.cshtml'
D:\workspace\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\6.0.0-beta.21263.1\tools\SymStore.targets(70,5): error MSB3073: The command ""D:\workspace\_work\1\s\.packages\microsoft.diasymreader.pdb2pdb\1.1.0-beta2-19575-01\tools\Pdb2Pdb.exe" "D:\workspace\_work\1\s\artifacts\bin\ReverseProxy.Auth.Sample\Release\net6.0\ReverseProxy.Auth.Sample.dll" /out "D:\workspace\_work\1\s\artifacts\SymStore\Release\ReverseProxy.Auth.Sample\net6.0\ReverseProxy.Auth.Sample.pdb" /srcsvrvar SRC_INDEX=public" exited with code -1. [D:\workspace\_work\1\s\samples\ReverseProxy.Auth.Sample\ReverseProxy.Auth.Sample.csproj]

@@ -1,12 +1,11 @@
{
"sdk": {
"version": "6.0.100-preview.3.21202.5"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While CI is happy with this, this should further wait for dotnet/sdk#17461 to be fixed so that we can continue working locally.

It was useful that we did this early to spot issues like the AspNetCore bug but it shouldn't be criticial to merge ASAP.

@MihaZupan MihaZupan marked this pull request as ready for review May 21, 2021 16:13
Comment on lines +414 to +415
// Future 6.0 builds will contain the fix to these missing converters
//#if !NET6_0_OR_GREATER
Copy link
Member Author

@MihaZupan MihaZupan May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tratcher this PR is now unblocked with the latest SDK+VS version.

I had to revert this #if until we start consuming future 6.0 builds with the json fix.

@MihaZupan MihaZupan removed the Blocked label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test YARP against .NET 6 previews
2 participants