-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add net6.0 targets #972
Add net6.0 targets #972
Conversation
7d2cbe4
to
1f95ba6
Compare
Bumped the SDK to Everything is now buildable and testable in 6.0, with the exception of the Auth Sample. That one is hitting the following error:
|
@@ -1,12 +1,11 @@ | |||
{ | |||
"sdk": { | |||
"version": "6.0.100-preview.3.21202.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While CI is happy with this, this should further wait for dotnet/sdk#17461 to be fixed so that we can continue working locally.
It was useful that we did this early to spot issues like the AspNetCore bug but it shouldn't be criticial to merge ASAP.
// Future 6.0 builds will contain the fix to these missing converters | ||
//#if !NET6_0_OR_GREATER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tratcher this PR is now unblocked with the latest SDK+VS version.
I had to revert this #if
until we start consuming future 6.0 builds with the json fix.
Blocked on dotnet/aspnetcore#32364 as some of the health check tests are hitting this.
Fixes #936