Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict mode for all dev code #1883

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Enable strict mode for all dev code #1883

merged 2 commits into from
Jun 14, 2023

Conversation

JiuqingSong
Copy link
Collaborator

  • Fix strict mode issues for TableResize plugin
  • Delete child tsconfig files
  • Enable strict mode in root level tsconfig file
  • Delete unused tsconfig.build.json
  • Still allow non-strict mode for test code and demo site

@JiuqingSong JiuqingSong merged commit c7c0b96 into master Jun 14, 2023
@JiuqingSong JiuqingSong deleted the u/jisong/strictmode branch June 14, 2023 17:59
@JiuqingSong JiuqingSong mentioned this pull request Jun 16, 2023
Merged
JiuqingSong added a commit that referenced this pull request Jun 16, 2023
@JiuqingSong @BryanValverdeU
@ianeli1 @juliaroldi @Andres-CT98 @tshibley @flyingbee2012 @cyanzhong @dependabot @shaipetel @Echo-az @charlxu @rickygao
Bump version to 8.50.0 (#1893)
1714273 
* Add Size Format Handler to tables (#1838)

* add width format handler

* Revert "add width format handler"

This reverts commit b36f17d58c260b74ad89ea8228cca274561cc702.

* add size handle to table

* add default style override when pasting table

* fix test

* revert

* Remove Table temp elements from Word Online (#1842)

* init

* fix test

* Remove the support of ShadowDOM entity (#1841)

* Undo with entity (#1791)

* Prototype: Undo with entity

* check entity type

* Content Model: Only optimize paragraph

* do not optimize entity

* fix build

* Improve

* improve

* improve

* fix test

* improve

* improve sample entity

* fix build

* improve

* Fix test

* Add  test

* fix test

* improve

* Content Model: Improve link and heading behavior (#1812)

* Improve link and heading behavior

* fix build

* improve format state, fix test

* Make roosterjs work with nodejs 17+ (#1849)

* Make roosterjs work with nodejs 17+

* update node version in workflow

* Content Model: Fix #1847 (#1848)

* Content Model: Fix #1847

* improve

* Fix config for test:coverage (#1851)

* Try fix #1816 (#1846)

* Add new param (#1853)

* Content Model: Maintain selection on empty line (#1814)

* Content Model: Maintain selection on empty line

* fix build

* improve

* Content Model: Fix #1802 Default format is not applied when type in a not-empty line (#1805)

* Try fix #1802

* fix build

* Improve

* fix test

* add more test

* Remove zeroFontSize from paragraph

* fix build

* fix bug

* fix test

* Improve

* fix test

* Fix list bug when pasting from Word Online (#1855)

Right now when copying from Word Online, if text is between 2 lists, the text between would be transformed to list too.
So we need to clear the list context to prevent this from happening. We will do this when:

Element is not wrapped in a ListContainerDiv
Element is not contained inside of a List item

* Make paste with content model a public api instead of a Editor Class member (#1852)

* init

* Remove unused function

* remove unused type

* Content Model: Fix #1839:  Fix toggleBold on heading text (#1845)

* Content Model: Fix #1839

* add test

---------

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Fix #1322: Copying some table structure transform the table to single line text (#1843)

* add width format handler

* Revert "add width format handler"

This reverts commit b36f17d58c260b74ad89ea8228cca274561cc702.

* add size handle to table

* add default style override when pasting table

* fix test

* revert

* fix

* address comment

* handle only on copy and cut

* Revert "address comment"

This reverts commit e2687957f1f92f57225ec82435bf994b90d5a9a2.

* handle only on cut and paste

* fix tests & build

* use onNodeCreated instead

* Improve test running (#1854)

* Use default format for empty line below entity (#1858)

* Use default format for empty line below entity

* fix build

* Fix bug when pasting from Outlook Win 32 to Rooster (#1857)

* init

* fix

* fix test in ff

* add a constants

* address comments

---------

Co-authored-by: Jiuqing Song <jisong@microsoft.com>

* Rename files and test files (#1856)

* add null check

* Add data to the ContentChange event when pasting (#1862)

When using paste we need to return the clipboardData when invoking addUndoSnapshot. That way when other plugins handle the ContentChangeEvent. They can also use the data property.
This is used for example in the PasteOption Plugin.

This PR adds this functionality to the new paste public API

Minor fix in promoteContentModelEditorCore since we were always adding the ContentModelCopyPastePlugin

* Update ContentModelCopyPaste Core Plugin state initialization. (#1867)

* init

* fix

* remove

* Fix table inserter for merged vertical cells (#1869)

* fix inserter

* fix comment

* changed to enum

* use Import Helpers to reduce pack size (#1865)

* Import Helpers

* add tslib dependency

---------

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Dismiss TableEditors when mouse is moved out of the editor. (#1863)

* init

* fix build

* remove unneeded exports

* Content Model: Let browser handle delete/backspace event for normal c… (#1870)

* Content Model: Let browser handle delete/backspace event for normal cases

* clear cache if let browser handle delete event

* fix test

---------

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Content Model: Fix focus issue again (#1872)

* Content Model: Patch for #1870 (#1873)

* Patch for #1870

* Use Content handle Ctrl+Backspace

* improve

* Fix some inconsistencies when pasting from Word (#1875)

* init

* add test

* fix build

* fix in firefox

* Add back onExternalContentTransform (#1874)

* Add back onExternalContentTransform

* fix test

* Content Model: Ignore empty paragraph when turn on list (#1868)

* Content Model: Ignore empty paragraph when turn on list

* Improve

* Improve

---------

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Content Model: Fix header level issue (#1876)

* Content Model: Fix header level issue

* fix test

* Fix Table Inserter Color in Dark Mode #1877

Co-authored-by: Jiuqing Song <jisong@microsoft.com>

* Merge Format when pasting. (#1866)

* add darkColorHandler to applyFormat

* remove changes

* Try fix 208247 (#1878)

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Content Model: Fix #209223 (#1879)

* Fix #209223

* fix build and test

* fix comments

* fix comments

* Enable strict mode for all dev code (#1883)

* Split demo site into two parts (#1880)

* Remove block background color on Merge Format after Paste (#1882)

* Fix #210328 (#1885)

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Content Model: Fix #209891 (#1886)

* Content Model: Fix #1887 (#1889)

* Content Model: Fix #1888 (#1891)

* RoosterJs 8.30.1 and Content Model 0.0.2 (#1217)

* Fix content model table bugs (#1214)

* Fix content model table bugs

* fix color bug

* Fix merge table cell behavior for ContentModel (#1216)

* Update version

* Content Model: fix table size when zoom (#1226) (#1235)

* fix merge issue

* RoosterJs 8.32.0 (#1290)

* test

* Move normalizeBlockquote from normalizePlugin to Format API (#1250)

* Content Model customization step 1: Reorganize some code (#1252)

* Reorganize some code

* fix build

* Move some code

* Remove unnecessary change

* More fix

* fix comment

* Content Model customization step 2: Customize element processor and default style (#1253)

* Reorganize some code

* fix build

* Move some code

* Remove unnecessary change

* More fix

* fix comment

* Customization 2

* temporarily allow empty interface

* ignore a lint rule

* fix: toggling inner list type #1258

Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Add getVisibleViewport function and hide TableSelector when is not inside of the Visible Rect (#1254)

* select image api

* remove code

* Content Model customization step 3: Customize format handlers (#1255)

* Reorganize some code

* fix build

* Move some code

* Remove unnecessary change

* More fix

* fix comment

* Customization 2

* temporarily allow empty interface

* ignore a lint rule

* Customization step 3

* Fix Cell Shade metadata (#1263)

* fix maintain list chain

* Remove Table Selection on Delete Row/Columns (#1260)

* ContentModel: BlockGroup is not Block (#1259)

* Reorganize some code

* fix build

* Move some code

* Remove unnecessary change

* More fix

* fix comment

* Customization 2

* temporarily allow empty interface

* ignore a lint rule

* Customization step 3

* BlockGroup is not Block

* fix comments

* Content Model: Add a temporary processor for DIV and SPAN (#1268)

* Add a temporary processor for DIV and SPAN

* fix build

* fix selectImageApi

* add initial test

* refactor 1

* improve

* remove nest

* update comment

* Try fix Unstable test by fixing clean up after each test #1277

* selectImageApi

* tag

* Add debug unit test commands to launch.json file #1278

* core adding image range

* Content Model: improve demo site, and minor bug fixes (#1271)

* Content Model: improve demo

* add more fix

* remove test case fix

* Skip unstable test case (#1280)

* select image data structure

* remove comment

* Image Selection plugin

* remove spaces

* test

* Use elements from list stack even if they don't match  (#1275)

* re-use list stack

* maybe fix some tests

* flag it

* better

* optional

* move call out of foreach

Co-authored-by: Jiuqing Song <jisong@microsoft.com>

* fix conflicts

* Remove 'caret-color' css rule when paste (#1283)

* Remove 'caret-color' css rule when paste

* fixtest

* refactor and add tests

* salve only image id instead of the the image element

* Enable strict mode for "packages-ui" (#1285)

* Enable strict mode

* Refactor create content model interfaces (#1273)

* RoosterJs 8.32.0

Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>
Co-authored-by: Trevor Shibley <trevor.shibley1@gmail.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Bi Wu <biwu@microsoft.com>
Co-authored-by: flyingbee2012 <wubiasu@gmail.com>
Co-authored-by: Trevor Shibley <trevor.shibley@frontapp.com>
Co-authored-by: Ian Elizondo <ianeli@microsoft.com>

* Publish Content Model 0.0.4 (#1308)

* Content Model List step 5: Add model format API (#1298)

* Content Model: improve demo

* add more fix

* Refactor create content model interfaces

* Remove duplicated TableCellMetadataFormat

* Add List types and views

* Add format handlers for list

* Add list processors and test

* Add handlers for list

* fix test

* fix test

* bug fix

* remove unnecessary change

* improve

* merge and fix

* Content Model List step 5: Add model format API

* Content Model List step 6: Public API (#1299)

* Content Model: improve demo

* add more fix

* Refactor create content model interfaces

* Remove duplicated TableCellMetadataFormat

* Add List types and views

* Add format handlers for list

* Add list processors and test

* Add handlers for list

* fix test

* fix test

* bug fix

* remove unnecessary change

* improve

* merge and fix

* Content Model List step 5: Add model format API

* Content Model List step 6: Public API

* Content Model Table bug fixes (#1305)

* Content Model Table bug fixes

* fix test

* Content Model List: Support "type" attribute of OL element (#1307)

* Content Model List: support "type" property of OL

* fix test

* Content Model 0.0.4

* 8.33.1: Fix #1310 (#1311)

* Fix context menu not working issue (#1309)

* Fix context menu not working issue

* fix build

* 8.33.1 Fix a bug in roosterjs-react

* Bump release to 8.33.2 (#1333)

* Content Model List step 5: Add model format API (#1298)

* Content Model: improve demo

* add more fix

* Refactor create content model interfaces

* Remove duplicated TableCellMetadataFormat

* Add List types and views

* Add format handlers for list

* Add list processors and test

* Add handlers for list

* fix test

* fix test

* bug fix

* remove unnecessary change

* improve

* merge and fix

* Content Model List step 5: Add model format API

* Content Model List step 6: Public API (#1299)

* Content Model: improve demo

* add more fix

* Refactor create content model interfaces

* Remove duplicated TableCellMetadataFormat

* Add List types and views

* Add format handlers for list

* Add list processors and test

* Add handlers for list

* fix test

* fix test

* bug fix

* remove unnecessary change

* improve

* merge and fix

* Content Model List step 5: Add model format API

* Content Model List step 6: Public API

* Content Model Table bug fixes (#1305)

* Content Model Table bug fixes

* fix test

* Content Model List: Support "type" attribute of OL element (#1307)

* Content Model List: support "type" property of OL

* fix test

* Enable strict mode for "roosterjs-editor-core/lib/corePlugins" (#1287)

* Enable strict mode

* Fix tests

* Revert remove typeAfterLink

* Remove optional chaining

* editor's contains and select can take null

* Update getDarkColor typings

* Fix context menu not working issue (#1309)

* Fix context menu not working issue

* fix build

* Update getSelectionRangeEx typings to match desc (#1312)

* Update getSelectionRangeEx typings to match desc

* Fix build

* Revert "Update getSelectionRangeEx typings to match desc (#1312)" (#1317)

This reverts commit a26001721e92a31e2ab810782e7d8f1f76fd8de8.

* Finish strict mode change for core package (#1318)

* Content Model Entity step 1 (#1313)

* trigger selection when click

* Content Model Entity step 2: Add implementation code (#1314)

* Content Model Entity step 1

* Content Model Entity step 2

* Content Model List bug fix (#1320)

* Content Model List bug fix

* add test case

* Support block format in Content Model step 1 (#1323)

* Support block format in Content Model step 1

* fix build

* Enable strict mode on "roosterjs-editor-plugins" - Phase 1 (#1289)

* Strict AutoFormat & ContextMenu

* Strict CustomReplace

* CutPasteListChain plugin

* Allow nullish dom attribute value

* Strict HyperLink

* Strict Watermark

* Use individual tsconfigs

* Check this.editor at start of onPluginEvent

* Support block format in Content Model step 2 (#1324)

* Support block format in Content Model step 1

* Support block format in Content Model step 2

* fix build

* fix test

* Allow insert entity on region root (#1316)

* Allow insert entity on region root

* improve

* fix comment

* Change version

* 8.34.0

Co-authored-by: Jiuqing Song <jisong@microsoft.com>
Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>

* Publish Content Model 0.0.5 (#1348)

* Customize Content Model step 1 (#1334)

* Customize Content Model step 2 (#1335)

* Customize Content Model step 3 (#1337)

* Customize Content Model step 1

* Customize Content Model step 2

* Customize Content Model step 3

* Fix content model table bugs (#1346)

* Content Model 0.0.5

* Fix empty line bug for content model (#1350)

* Fix empty line bug for content model

* fix test

* fix merge issue

* Version bump 8.35.2 to 8.36.0 (#1403)

* WIP

* WIP

* enable flight

* adapt Image Edit to Image Selection

* typo

* compare files

* add image selection

* remove alignment

* typo

* if click in image, select it

* remove check

* picker plugin tests

* setEditing

* change variable names

* WIP

* WIP

* WIP

* change to mouse up

* remove comment

* remove comment

* fix copy/paste

* dispose properties

* add test

* Enable strict mode for color utils (#1319)

* use queryelements

* Change the order of karma plugins (#1371)

* Remove empty div Between list when backspacing. (#1365)

* init

* Check if prevElement is List, to avoid perf issue

* remove debugger

* Fix dependency iss

* Do not merge if lists have different type

* use Editor Document

* Make strings constant

* add checker

* Content Model Bug fix: part 1 (#1370)

* Bug bash bug fix

* fix test

* improve

* WIP

* new update wrapper

* Content Model bug fix part 2: Support hyperlink and better support align (#1376)

* Bug bash bug fix

* fix test

* improve

* Bug bash bug fix 2: Better support align

* Fix test

* Improve hyper link

* improve

* add null check

* add const to metadata

* add null check and list chain

* refactor image edit

* Apply default format on SPAN instead of DIV (#1380)

* Apply default format in SPAN

* Enable in demo site by default

* fix test

* refactor

* Fix changing font size doesn't work for empty selections (#1384)

Co-authored-by: Ying Zhong <yinzhon@microsoft.com>

* refactor

* Content Model Bug bash fix part 3: More content fidelity fixes (#1378)

* Bug bash bug fix

* fix test

* improve

* Bug bash bug fix 2: Better support align

* Fix test

* Improve hyper link

* improve

* Content Model bug fix part 3: More content fidelity fix

* Fix more bugs

* add more test

* use remove global styles

* use clone to applay changes

* refactor

* Content Model Bug bash fix part 4: More content fidelity fixes (#1386)

* Bug bash bug fix

* fix test

* improve

* Bug bash bug fix 2: Better support align

* Fix test

* Improve hyper link

* improve

* Content Model bug fix part 3: More content fidelity fix

* Fix more bugs

* add more test

* More fidelity fixes

* fix test

* Content Model: Better support dataset and metadata step 1 of 5: New dataset and metadata API, and apply to image (#1388)

* Content Model: Better support dataset and metadata step 1: New dataset and metadata API, and apply to image

* fix build

* Content Model: Better support dataset and metadata step 2 of 5: Port Table Cell metadata (#1389)

* Content Model: Better support dataset and metadata step 1: New dataset and metadata API, and apply to image

* fix build

* Content Model metadata step 2

* Content Model: Better support dataset and metadata step 3 of 5: Port Table metadata (#1390)

* Content Model: Better support dataset and metadata step 1: New dataset and metadata API, and apply to image

* fix build

* Content Model metadata step 2

* Content Model Metadata step 3

* fix build

* Content Model: Better support dataset and metadata step 4 of 5: Port list metadata (#1391)

* Content Model: Better support dataset and metadata step 1: New dataset and metadata API, and apply to image

* fix build

* Content Model metadata step 2

* Content Model Metadata step 3

* fix build

* Content Model metadata step 4

* fix test

* Content Model: Better support dataset and metadata step 5 of 5: Port hyperlink dataset (#1393)

* Content Model: Better support dataset and metadata step 1: New dataset and metadata API, and apply to image

* fix build

* Content Model metadata step 2

* Content Model Metadata step 3

* fix build

* Content Model metadata step 4

* fix test

* Content Model metadata step 5

* fix build

* Fix image zoom scale while editing (#1383)

* fix zoom sacle

* WIP

* fix zoom

* remove scale property

Co-authored-by: Jiuqing Song <jisong@microsoft.com>

* Graduate experimental features (#1385)

* graduate experimental features

* graduate experimental features

* deprecate

Co-authored-by: Jiuqing Song <jisong@microsoft.com>

* More ImageSelection plugin into core plugin (#1395)

* Content Model: Provide default settings in context so overriding functions can call it (#1396)

* Provide default settings in context so overriding functions can call it

* fix build

* Remove unused code

* Content Model: reorganize some code (#1394)

* Content Model: Better support dataset and metadata step 1: New dataset and metadata API, and apply to image

* fix build

* Content Model metadata step 2

* Content Model Metadata step 3

* fix build

* Content Model metadata step 4

* fix test

* Content Model metadata step 5

* fix build

* Reorg Content Model code

* Bump socket.io-parser from 4.0.4 to 4.0.5 (#1397)

Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io-parser/compare/4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix list style issue (#1399)

* Fix list style issue

* fix bug and test cases

* Bump minimatch from 3.0.4 to 3.1.2 (#1398)

Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Commits](https://github.com/isaacs/minimatch/compare/v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jiuqing Song <jisong@microsoft.com>

* Content Model: Fix two list issues (#1400)

* Content Model: Fix two list issues

* Fix implicit

* Apply default format on SPAN instead of DIV (#1380)

* Apply default format in SPAN

* Enable in demo site by default

* fix test

* version bump 8.36.0

* bumped Content model version too.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Jiuqing Song <jisong@microsoft.com>
Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>
Co-authored-by: Gnohz Gniy <0x00eeee@gmail.com>
Co-authored-by: Ying Zhong <yinzhon@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Publish the fix to Content Model image size bug (#1412)

* Fix image size in Content Model (#1411)

* Fix image size bug

* Content Model: fix inline entity loses format issue (#1416), Publish Content Model 0.0.8 (#1418)

* Content Model: fix inline entity loses format issue (#1416)

* Content Model: fix inline entity loses format issue

* improve

* fix build

* fix build

* Publish 8.37.0 with 4 changes (#1430)

* Fix a list color issue in dark mode (#1428) (#1429)

* Fix a list color issue in dark mode

* fix test

* Add test

* Improve shadow edit behavior when there is entity in editor (#1408)

* Move mergeFragmentWithEntity to roosterjs

* Shadow edit with entity

* 8.37.0

* Merge pull request #1425 from microsoft/u/juliaroldi/auto-format-list-special-char

Valid numbering

* Merge pull request #1426 from microsoft/u/juliaroldi/previous-line-bug

Fix cursor jump bug.

Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>

* fix conflicts

* bump content model

* Bump Rooster to 8.39.0 (#1450)

* get biggest z index

* comment

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor and comments

* refactor

* Improve handling of quotes inside lists (#1438)

* Remove coloring when removing a quote inside a LI

* Prevent list items from being removed before quote

* refactor

* Content Model Support PRE and CODE: step 1 (#1439)

* Support PRE and CODE: step 1

* improve

* Content Model Support PRE and CODE: step 2 (#1440)

* Support PRE and CODE: step 1

* improve

* Support PRE and CODE step 2

* Fix issue when cell resizing with merged cells (#1445)

* init

* Fix

* Content Model Support PRE and CODE: step 3 (#1441)

* Support PRE and CODE: step 1

* improve

* Support PRE and CODE step 2

* Support PRE and CODE: step 3

* Content Model Support PRE and CODE: step 4 (#1442)

* Support PRE and CODE: step 1

* improve

* Support PRE and CODE step 2

* Support PRE and CODE: step 3

* Support PRE and CODE: step 4

* Allow styled table header cells to be clear formatted (#1447)

* Consider nodes with siblings with no text as empty

* Cleanup

* Fix background color issue that can go across block element (#1448)

* Fix Unhandled Rejection: Error: Editor is already disposed (#1449)

* Fix issue

* fix test

* Bump

* Bump content model

Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Jiuqing Song <jisong@microsoft.com>
Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Bump 8.39.1 (#1453)

* WIP

* get biggest z index

* comment

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor

* refactor and comments

* refactor

* Improve handling of quotes inside lists (#1438)

* Remove coloring when removing a quote inside a LI

* Prevent list items from being removed before quote

* refactor

* Content Model Support PRE and CODE: step 1 (#1439)

* Support PRE and CODE: step 1

* improve

* Content Model Support PRE and CODE: step 2 (#1440)

* Support PRE and CODE: step 1

* improve

* Support PRE and CODE step 2

* Fix issue when cell resizing with merged cells (#1445)

* init

* Fix

* Content Model Support PRE and CODE: step 3 (#1441)

* Support PRE and CODE: step 1

* improve

* Support PRE and CODE step 2

* Support PRE and CODE: step 3

* fix markdown feature

* fix test

* Content Model Support PRE and CODE: step 4 (#1442)

* Support PRE and CODE: step 1

* improve

* Support PRE and CODE step 2

* Support PRE and CODE: step 3

* Support PRE and CODE: step 4

* Allow styled table header cells to be clear formatted (#1447)

* Consider nodes with siblings with no text as empty

* Cleanup

* Fix background color issue that can go across block element (#1448)

* Fix Unhandled Rejection: Error: Editor is already disposed (#1449)

* Fix issue

* fix test

* Fix #1443: Support CSS style word-break in ContentModel for table cell (#1451)

* Fix #1443

* fix build

* fix test

* Bump

* bump content model

Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Jiuqing Song <jisong@microsoft.com>
Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Bump Rooster to 8.40.2 and ContentModel to 0.0.13 (#1522)

* convert alpha to decimals

* fix auto format list

* add null and refactor

* Content Model Selection API step 4: Refactor existing table API (#1479)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Support element with namespace (#1489)

* Content Model: Fix a bug when process margin (#1493)

* Fix margin issue

* Fix test

* Fix A tag without href (#1495)

* Fix Cut/Copy page scroll issue (#1496)

* Fix Cut/Copy page scroll issue

* Fix test

* fix image plugin z-index calc

* Content Model Format State Step 1: Refactor formatSegmentWithContentModel() (#1490)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* Improve

* update condition per comments

* Content Model Format State Step 2: Allow retrieving metadata directly (#1491)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* Improve

* Content Model Format State Step 3: Add getFormatState API and ContentModelPlugin (#1492)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* Content Model: Add API clearFormat (#1497)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* remove wrapper when content change

* fix

* Content Model: Move format API: link, image, captalization, ... (#1506)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* ContentModel: Support insertLink and removeLink

* changeCapitalization and setImageAltText

* fix for image selection

* refactor

* refactor

* Fix #1509 (#1511)

* ContentModel: Improve Divider (#1513)

* ContentModel: Improve Divider

* Add BorderFormat to ContentModelBlockFormat

* Add test

* fix build

* Content Model: Support "no color" when set color (#1514)

* Content Model: Support "no color" when set color

* improve

* Content Model: Use Entity handle readonly element (#1515)

* Content Model: Support get and apply segment format (#1518)

* Do not merge table when insert a table (#1519)

* bump versions

* Content Model: Fix #1239 (#1521)

Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Jiuqing Song <jisong@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Shai Petel <shai@kwizcom.com>
Co-authored-by: Shai Petel <shai@petel.com>

* Version bump: Roosterjs 8.41.0 (#1537)

* convert alpha to decimals

* fix auto format list

* add null and refactor

* Content Model Selection API step 4: Refactor existing table API (#1479)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Support element with namespace (#1489)

* Content Model: Fix a bug when process margin (#1493)

* Fix margin issue

* Fix test

* Fix A tag without href (#1495)

* Fix Cut/Copy page scroll issue (#1496)

* Fix Cut/Copy page scroll issue

* Fix test

* fix image plugin z-index calc

* Content Model Format State Step 1: Refactor formatSegmentWithContentModel() (#1490)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* Improve

* update condition per comments

* Content Model Format State Step 2: Allow retrieving metadata directly (#1491)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* Improve

* Content Model Format State Step 3: Add getFormatState API and ContentModelPlugin (#1492)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* Content Model: Add API clearFormat (#1497)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* remove wrapper when content change

* fix

* Content Model: Move format API: link, image, captalization, ... (#1506)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* ContentModel: Support insertLink and removeLink

* changeCapitalization and setImageAltText

* fix for image selection

* refactor

* refactor

* Test image edit with ShadowDOM

* improve

* Fix #1509 (#1511)

* ContentModel: Improve Divider (#1513)

* ContentModel: Improve Divider

* Add BorderFormat to ContentModelBlockFormat

* Add test

* fix build

* Content Model: Support "no color" when set color (#1514)

* Content Model: Support "no color" when set color

* improve

* Content Model: Use Entity handle readonly element (#1515)

* image wrapper using shadow dom

* Content Model: Support get and apply segment format (#1518)

* Do not merge table when insert a table (#1519)

* Content Model: Fix #1239 (#1521)

* WIP AND fix for span height

* stop dragging

* comment

* prevent drag

* remove new max-width

* Load fluent ui from cdnjs (#1525)

* Content Model: Improve selection (#1526)

* Apply format to word where cursor is located (#1367)

* attempt with traversers

* attempt using splitTextNode

* Return to original implementation

* Fix build

* implementation with content model

* Implement word selection with new content model

* removed selectWordFromCollapsedRange.ts

* optimization fixes and file changes

* standardize function and remove castings

* fix paragraph and pending state

* fix pending state, name change

* Added test cases, disabled end or start of word

* fixed dependency

* fix pending state

* more tests

* fixed tests

* End of word format fix (#1528)

* End of word format fix

Fix scenario where format was wrongly applied where the cursor was located at the end of a word

* add tests

* Variable based dark color (#1531)

* Variable based dark color

* fix test

* improve

* Improve

* Fix comment

* Fix #1532: Support isCode in FormatState (#1533)

* Fix #1532

* add comment

* fix build

* fix comment

* Bump ua-parser-js from 0.7.31 to 0.7.33 (#1535)

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix #1529 #1530 and 187095 (#1534)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Shai Petel <shai@kwizcom.com>
Co-authored-by: Shai Petel <shai@petel.com>
Co-authored-by: Andres-CT98 <107568016+Andres-CT98@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump Content Model version to 0.0.15 (#1542)

* convert alpha to decimals

* fix auto format list

* add null and refactor

* Content Model Selection API step 4: Refactor existing table API (#1479)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Support element with namespace (#1489)

* Content Model: Fix a bug when process margin (#1493)

* Fix margin issue

* Fix test

* Fix A tag without href (#1495)

* Fix Cut/Copy page scroll issue (#1496)

* Fix Cut/Copy page scroll issue

* Fix test

* fix image plugin z-index calc

* Content Model Format State Step 1: Refactor formatSegmentWithContentModel() (#1490)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* Improve

* update condition per comments

* Content Model Format State Step 2: Allow retrieving metadata directly (#1491)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* Improve

* Content Model Format State Step 3: Add getFormatState API and ContentModelPlugin (#1492)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* Content Model: Add API clearFormat (#1497)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* remove wrapper when content change

* fix

* Content Model: Move format API: link, image, captalization, ... (#1506)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* ContentModel: Support insertLink and removeLink

* changeCapitalization and setImageAltText

* fix for image selection

* refactor

* refactor

* Test image edit with ShadowDOM

* improve

* Fix #1509 (#1511)

* ContentModel: Improve Divider (#1513)

* ContentModel: Improve Divider

* Add BorderFormat to ContentModelBlockFormat

* Add test

* fix build

* Content Model: Support "no color" when set color (#1514)

* Content Model: Support "no color" when set color

* improve

* Content Model: Use Entity handle readonly element (#1515)

* image wrapper using shadow dom

* Content Model: Support get and apply segment format (#1518)

* Do not merge table when insert a table (#1519)

* Content Model: Fix #1239 (#1521)

* WIP AND fix for span height

* stop dragging

* comment

* prevent drag

* remove new max-width

* Load fluent ui from cdnjs (#1525)

* Content Model: Improve selection (#1526)

* Apply format to word where cursor is located (#1367)

* attempt with traversers

* attempt using splitTextNode

* Return to original implementation

* Fix build

* implementation with content model

* Implement word selection with new content model

* removed selectWordFromCollapsedRange.ts

* optimization fixes and file changes

* standardize function and remove castings

* fix paragraph and pending state

* fix pending state, name change

* Added test cases, disabled end or start of word

* fixed dependency

* fix pending state

* more tests

* fixed tests

* End of word format fix (#1528)

* End of word format fix

Fix scenario where format was wrongly applied where the cursor was located at the end of a word

* add tests

* Variable based dark color (#1531)

* Variable based dark color

* fix test

* improve

* Improve

* Fix comment

* Fix #1532: Support isCode in FormatState (#1533)

* Fix #1532

* add comment

* fix build

* fix comment

* Bump ua-parser-js from 0.7.31 to 0.7.33 (#1535)

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix #1529 #1530 and 187095 (#1534)

* Content Model: Adjust selection for link to select a word (#1538)

* Content Model: Adjust word selection for link

* add test

* fix build

* Fix table format (#1541)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Shai Petel <shai@kwizcom.com>
Co-authored-by: Shai Petel <shai@petel.com>
Co-authored-by: Andres-CT98 <107568016+Andres-CT98@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump Rooster to 8.42.0 (#1571)

* convert alpha to decimals

* fix auto format list

* add null and refactor

* Content Model Selection API step 4: Refactor existing table API (#1479)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Support element with namespace (#1489)

* Content Model: Fix a bug when process margin (#1493)

* Fix margin issue

* Fix test

* Fix A tag without href (#1495)

* Fix Cut/Copy page scroll issue (#1496)

* Fix Cut/Copy page scroll issue

* Fix test

* fix image plugin z-index calc

* Content Model Format State Step 1: Refactor formatSegmentWithContentModel() (#1490)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* Improve

* update condition per comments

* Content Model Format State Step 2: Allow retrieving metadata directly (#1491)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* Improve

* Content Model Format State Step 3: Add getFormatState API and ContentModelPlugin (#1492)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* wip

* WIP

* wip

* Content Model: Add API clearFormat (#1497)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* remove wrapper when content change

* fix

* Content Model: Move format API: link, image, captalization, ... (#1506)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* ContentModel: Support insertLink and removeLink

* changeCapitalization and setImageAltText

* fix for image selection

* refactor

* refactor

* Test image edit with ShadowDOM

* improve

* Fix #1509 (#1511)

* ContentModel: Improve Divider (#1513)

* ContentModel: Improve Divider

* Add BorderFormat to ContentModelBlockFormat

* Add test

* fix build

* Content Model: Support "no color" when set color (#1514)

* Content Model: Support "no color" when set color

* improve

* Content Model: Use Entity handle readonly element (#1515)

* image wrapper using shadow dom

* Content Model: Support get and apply segment format (#1518)

* Do not merge table when insert a table (#1519)

* wip

* Content Model: Fix #1239 (#1521)

* WIP AND fix for span height

* stop dragging

* comment

* prototype

* remove change

* prevent drag

* remove new max-width

* Load fluent ui from cdnjs (#1525)

* small changes

* Content Model: Improve selection (#1526)

* Apply format to word where cursor is located (#1367)

* attempt with traversers

* attempt using splitTextNode

* Return to original implementation

* Fix build

* implementation with content model

* Implement word selection with new content model

* removed selectWordFromCollapsedRange.ts

* optimization fixes and file changes

* standardize function and remove castings

* fix paragraph and pending state

* fix pending state, name change

* Added test cases, disabled end or start of word

* fixed dependency

* fix pending state

* more tests

* fixed tests

* End of word format fix (#1528)

* End of word format fix

Fix scenario where format was wrongly applied where the cursor was located at the end of a word

* add tests

* Variable based dark color (#1531)

* Variable based dark color

* fix test

* improve

* Improve

* Fix comment

* Fix #1532: Support isCode in FormatState (#1533)

* Fix #1532

* add comment

* fix build

* fix comment

* Bump ua-parser-js from 0.7.31 to 0.7.33 (#1535)

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix #1529 #1530 and 187095 (#1534)

* WIP

* test and fixes

* unit tests

* fix list trigger

* Content Model: Adjust selection for link to select a word (#1538)

* Content Model: Adjust word selection for link

* add test

* fix build

* Fix table format (#1541)

* refactor

* move comment

* Content Model code simplify 1 (#1544)

* Content Model code simplify 2: Clean up EditorContext (#1545)

* Content Model code simplify 1

* Content Model: Clean up EditorContext

* improve

* Content Model code simplify 3: Remove get/setPendingFormat from editor interface (#1546)

* Content Model code simplify 1

* Content Model: Clean up EditorContext

* improve

* Content Model: Remove get/setPendingFormat

* Add support for paragraph line spacing for content model (#1543)

* Fetch line height from children

* Create new content model api

* Spacing btn

* Fix tests

* Remove key from roosterjs-react

* testing

* Allow segment to hold lineHeight format

* Remove lineHeight from segments whenever possible

* Fix imports

* Remove normalization

* Add todo for edge case

* Render segment line height

* Content Model Editor 1: Rename interface IExperimentalContentModelEditor (#1547)

* Content Model code simplify 1

* Content Model: Clean up EditorContext

* improve

* Content Model: Remove get/setPendingFormat

* Content Model: Rename IExperimentalContentModelEditor

* fix build

* Content Model Editor 2: Publish ContentModelEditor class (#1548)

* Content Model code simplify 1

* Content Model: Clean up EditorContext

* improve

* Content Model: Remove get/setPendingFormat

* Content Model: Rename IExperimentalContentModelEditor

* Publish ContentModelEditor class

* fix build

* add test

* fix build

* fix build

* Reorganize Contente Model code (#1555)

* blur issue

* Fix some block format issues (#1554)

* Fix some block format issues

* Improve

* Content Model: Fix image size for outlook (#1556)

* Content Model: Fix image size for outlook

* Fix build

* fix build

* improve

* add filter to client rects

* Content Model: Support align table to center (#1557)

* simply code

* Content Model: Fix PRE tag (#1559)

* Content Model: Support insert image with src (#1563)

* Content Model: Get init segment format from root container (#1567)

* Content Model: Get init segment format from root container

* Improve

* add test

* Add missing setSpacing comment (#1564)

* do not call updateHandle

* check viewport

* Content Model: Improve pending format implementation (#1570)

* Disable list indentation on mac (#1552)

* Disable list indentation on mac

* Switch to default disabled

* Content Model: Improve hyperlink handling (#1569)

* backu

* remove unneeded changes

* bump RoosterJS version

* Add support for adding/removing space before/after paragraphs in content model (#1565)

* Create api for block margins

* Create space before after buttons

* Update testing

* Fix by using decorator

* Replace positive value with none

* Treat no margin as space removed

* Fix testing

* Improve tag name selecting

* testing

* rename and improve logic

* Add support for formatState on onClick call

* Update button impl

* Revert "Update button impl"

This reverts commit edce3ad11d1bb6841461f40e494b3df3207459e2.

* Revert "Add support for formatState on onClick call"

This reverts commit 3d6b83d0f22e1224868f7730eface582014e68f0.

* use getFormatState()

* Update test name

* Bump Content Model version

* Fix a pending format issue in firefox (#1572)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Jiuqing Song <jisong@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Shai Petel <shai@kwizcom.com>
Co-authored-by: Shai Petel <shai@petel.com>
Co-authored-by: Andres-CT98 <107568016+Andres-CT98@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ian Elizondo <ianeli@microsoft.com>

* Bump Rooster to 8.43.0, Content Model to 0.1.2 (#1604)

* convert alpha to decimals

* fix auto format list

* add null and refactor

* Content Model Selection API step 4: Refactor existing table API (#1479)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Support element with namespace (#1489)

* Content Model: Fix a bug when process margin (#1493)

* Fix margin issue

* Fix test

* Fix A tag without href (#1495)

* Fix Cut/Copy page scroll issue (#1496)

* Fix Cut/Copy page scroll issue

* Fix test

* fix image plugin z-index calc

* Content Model Format State Step 1: Refactor formatSegmentWithContentModel() (#1490)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* Improve

* update condition per comments

* Content Model Format State Step 2: Allow retrieving metadata directly (#1491)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* Improve

* Content Model Format State Step 3: Add getFormatState API and ContentModelPlugin (#1492)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* wip

* WIP

* wip

* Content Model: Add API clearFormat (#1497)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* remove wrapper when content change

* fix

* Content Model: Move format API: link, image, captalization, ... (#1506)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* ContentModel: Support insertLink and removeLink

* changeCapitalization and setImageAltText

* fix for image selection

* refactor

* refactor

* Test image edit with ShadowDOM

* improve

* Fix #1509 (#1511)

* ContentModel: Improve Divider (#1513)

* ContentModel: Improve Divider

* Add BorderFormat to ContentModelBlockFormat

* Add test

* fix build

* Content Model: Support "no color" when set color (#1514)

* Content Model: Support "no color" when set color

* improve

* Content Model: Use Entity handle readonly element (#1515)

* image wrapper using shadow dom

* Content Model: Support get and apply segment format (#1518)

* Do not merge table when insert a table (#1519)

* wip

* Content Model: Fix #1239 (#1521)

* WIP AND fix for span height

* stop dragging

* comment

* prototype

* remove change

* prevent drag

* remove new max-width

* Load fluent ui from cdnjs (#1525)

* small changes

* Content Model: Improve selection (#1526)

* Apply format to word where cursor is located (#1367)

* attempt with traversers

* attempt using splitTextNode

* Return to original implementation

* Fix build

* implementation with content model

* Implement word selection with new content model

* removed selectWordFromCollapsedRange.ts

* optimization fixes and file changes

* standardize function and remove castings

* fix paragraph and pending state

* fix pending state, name change

* Added test cases, disabled end or start of word

* fixed dependency

* fix pending state

* more tests

* fixed tests

* End of word format fix (#1528)

* End of word format fix

Fix scenario where format was wrongly applied where the cursor was located at the end of a word

* add tests

* Variable based dark color (#1531)

* Variable based dark color

* fix test

* improve

* Improve

* Fix comment

* Fix #1532: Support isCode in FormatState (#1533)

* Fix #1532

* add comment

* fix build

* fix comment

* Bump ua-parser-js from 0.7.31 to 0.7.33 (#1535)

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix #1529 #1530 and 187095 (#1534)

* WIP

* test and fixes

* unit tests

* fix list trigger

* Content Model: Adjust selection for link to select a word (#1538)

* Content Model: Adjust word selection for link

* add test

* fix build

* Fix table format (#1541)

* refactor

* move comment

* Content Model code simplify 1 (#1544)

* Content Model code simplify 2: Clean up EditorContext (#1545)

* Content Model code simplify 1

* Content Model: Clean up EditorContext

* improve

* Content Model code simplify 3: Remove get/setPendingFormat from editor interface (#1546)

* Content Model code simplify 1

* Content Model: Clean up EditorContext

* improve

* Content Model: Remove get/setPendingFormat

* Add support for paragraph line spacing for content model (#1543)

* Fetch line height from children

* Create new content model api

* Spacing btn

* Fix tests

* Remove key from roosterjs-react

* testing

* Allow segment to hold lineHeight format

* Remove lineHeight from segments whenever possible

* Fix imports

* Remove normalization

* Add todo for edge case

* Render segment line height

* Content Model Editor 1: Rename interface IExperimentalContentModelEditor (#1547)

* Content Model code simplify 1

* Content Model: Clean up EditorContext

* improve

* Content Model: Remove get/setPendingFormat

* Content Model: Rename IExperimentalContentModelEditor

* fix build

* WIP PROTOTYPE

* Content Model Editor 2: Publish ContentModelEditor class (#1548)

* Content Model code simplify 1

* Content Model: Clean up EditorContext

* improve

* Content Model: Remove get/setPendingFormat

* Content Model: Rename IExperimentalContentModelEditor

* Publish ContentModelEditor class

* fix build

* add test

* fix build

* fix build

* Reorganize Contente Model code (#1555)

* blur issue

* Fix some block format issues (#1554)

* Fix some block format issues

* Improve

* Content Model: Fix image size for outlook (#1556)

* Content Model: Fix image size for outlook

* Fix build

* fix build

* improve

* add filter to client rects

* Content Model: Support align table to center (#1557)

* simply code

* Content Model: Fix PRE tag (#1559)

* Content Model: Support insert image with src (#1563)

* Content Model: Get init segment format from root container (#1567)

* Content Model: Get init segment format from root container

* Improve

* add test

* Add missing setSpacing comment (#1564)

* do not call updateHandle

* check viewport

* Content Model: Improve pending format implementation (#1570)

* Disable list indentation on mac (#1552)

* Disable list indentation on mac

* Switch to default disabled

* Content Model: Improve hyperlink handling (#1569)

* Add support for adding/removing space before/after paragraphs in content model (#1565)

* Create api for block margins

* Create space before after buttons

* Update testing

* Fix by using decorator

* Replace positive value with none

* Treat no margin as space removed

* Fix testing

* Improve tag name selecting

* testing

* rename and improve logic

* Add support for formatState on onClick call

* Update button impl

* Revert "Update button impl"

This reverts commit edce3ad11d1bb6841461f40e494b3df3207459e2.

* Revert "Add support for formatState on onClick call"

This reverts commit 3d6b83d0f22e1224868f7730eface582014e68f0.

* use getFormatState()

* Update test name

* Fix a pending format issue in firefox (#1572)

* Content Model: Keep root level entity when format with Content Model (#1573)

* Content Model: Preserve segment format when insert table (#1574)

* delete table

* fix enum

* refactor

* Fix #1585 (#1587)

* strict mode

* remove file

* add zeros

* enable strict mode

* Content Model: Improve clearFormat API (#1579)

* Content Model:  Improve clearFormat

* Improve

* Improve

* fix build

* improve

* WIP

* Content Model: Improve getFormatState (#1594)

* Fix color issue with Font tag (#1595)

* refactor

* Fix #1586 (#1597)

* Add `dir` and `textAlign` in `FormatState` (#1590)

Co-authored-by: Echo Li <yalinli@microsoft.com>

* uncoment

* Step 1: Add HTMLSpanElements around ReadOnly Inline entities to prevent cursor issues, (#1580)

* init

* add tests and build fixes

* Fix failing tests in EntityPlugin

* Fix comments

* Fix comments

* Move functionality to insertEntity

* typedoc

* refactor

* refactor

* add tests

* Content Model: Improve pending format behavior (#1598)

* Improve pending format behavior

* fix test

* Add flight check in InsertEntity #1602

* Improve PRE again (#1601)

* Bump versions to 8.43.0

* Bump content model

* Remove duplicate implementation

* Change content model version to 0.2.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Júlia Roldi <juliaroldi@microsoft.com>
Co-authored-by: Jiuqing Song <jisong@microsoft.com>
Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Co-authored-by: Shai Petel <shai@kwizcom.com>
Co-authored-by: Shai Petel <shai@petel.com>
Co-authored-by: Andres-CT98 <107568016+Andres-CT98@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Echo-az <63284518+Echo-az@users.noreply.github.com>
Co-authored-by: Echo Li <yalinli@microsoft.com>
Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com>

* Bump version to 8.44.0 (#1627)

* convert alpha to decimals

* fix auto format list

* add null and refactor

* Content Model Selection API step 4: Refactor existing table API (#1479)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Support element with namespace (#1489)

* Content Model: Fix a bug when process margin (#1493)

* Fix margin issue

* Fix test

* Fix A tag without href (#1495)

* Fix Cut/Copy page scroll issue (#1496)

* Fix Cut/Copy page scroll issue

* Fix test

* fix image plugin z-index calc

* Content Model Format State Step 1: Refactor formatSegmentWithContentModel() (#1490)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* Improve

* update condition per comments

* Content Model Format State Step 2: Allow retrieving metadata directly (#1491)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* Improve

* Content Model Format State Step 3: Add getFormatState API and ContentModelPlugin (#1492)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* wip

* WIP

* wip

* Content Model: Add API clearFormat (#1497)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* remove wrapper when content change

* fix

* Content Model: Move format API: link, image, captalization, ... (#1506)

* Selection API step 1

* Selection API 2

* New selection API

* Refactor table API

* add  test

* Format state step 1

* FormatState step 2

* FormatState step 3: Add getFormatState API and ContentModel plugin

* Improve

* Content Model: clearFormat

* fix build

* Improve

* Improve

* fix test

* improve, fix safari issue

* fix test

* ContentModel: Support insertLink and removeLink

* changeCapitalization and setImageAltText

* fix for image selection

* refactor

* refactor

* Test image edit with ShadowDOM

* improve

* Fix #1509 (#1511)

* ContentModel: Improve Divider (#1513)

* ContentModel: Improve Divider

* Add BorderFormat to ContentModelBlockFormat

* Add test

* fix build

* Content Model: Support "no color" when set color (#1514)

* Content Model: Support "no color" when set color

* improve

* Content Model: Use Entity handle readonly element (#1515)

* image wrapper using shadow dom

* Content Model: Support get and apply segment format (#1518)

* Do not merge table when insert a table (#1519)

* wip

* Content Model: Fix #1239 (#1521)

* WIP AND fix for span height

* stop dragging

* comment

* prototype

* remove change

* prevent drag

* remove new max-width

* Load fluent ui from cdnjs (#1525)

* small changes

* Content Model: Improve sele…
This was referenced Jun 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaroldi juliaroldi juliaroldi approved these changes

@flyingbee2012 flyingbee2012 Awaiting requested review from flyingbee2012

@BryanValverdeU BryanValverdeU Awaiting requested review from BryanValverdeU

@ianeli1 ianeli1 Awaiting requested review from ianeli1

@Andres-CT98 Andres-CT98 Awaiting requested review from Andres-CT98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiuqingSong @juliaroldi