If not merging Paragraphs, keep the source format #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
changed the title
BryanValverdeU
requested review from
flyingbee2012,
JiuqingSong,
ianeli1,
juliaroldi and
Andres-CT98
JiuqingSong
reviewed
Jul 14, 2023
| @@ -132,6 +132,10 @@ function mergeParagraph( | |||
| if (newPara.decorator) { | |||
| newParagraph.decorator = { ...newPara.decorator }; | |||
| } | |||
|
|
|||
| if (!mergeToCurrentParagraph) { | |||
| newParagraph.format = newPara.format; | |||
There was a problem hiding this comment.
Isn't this format already applied in line 228?
There was a problem hiding this comment.
Oh I got it, so this is to remove existing format from source block
There was a problem hiding this comment.
Yes, it seems that in some cases, when we split the paragraph, the previous paragraph's format is applied to the markerPosition's paragraph.
I think this might not be okay, because it is causing the subsecuent paragraphs to also get the format even if they do not have it.
JiuqingSong
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we merge some content with Table and a paragraph. The block format of the table (All the borders,etc) is leaking to the paragraphs that are after the table.
So, if we are not merging To Current Paragraph, keep using the format of the source block.
See gifs attached here for the before and after:
https://outlookweb.visualstudio.com/Outlook%20Web/_workitems/edit/215985/