Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo site improvement for Content Model #1966

Merged
merged 5 commits into from
Jul 21, 2023
Merged

Demo site improvement for Content Model #1966

merged 5 commits into from
Jul 21, 2023

Conversation

JiuqingSong
Copy link
Collaborator

@JiuqingSong JiuqingSong commented Jul 20, 2023 •
edited
Loading

  1. Enable experimental feature ContentModelPaste in demo site by default
  2. Enable content model paste plugin in demo site by default
  3. Provide a button in side pane to generate code for Content Model editor into CodePen
  4. Remove CutPasteListChain from Content Model demo site since we don't need it for Content Model

image

BryanValverdeU
BryanValverdeU reviewed Jul 20, 2023
View reviewed changes
demo/scripts/controls/sidePane/editorOptions/ContentModelEditorOptionsPlugin.ts Outdated
@@ -12,7 +12,7 @@ const initialState: BuildInPluginState = {
paste: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also disable this paste plugin

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@JiuqingSong JiuqingSong merged commit 997fd1f into master Jul 21, 2023
@JiuqingSong JiuqingSong deleted the u/jisong/demositeimprovement branch July 21, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanValverdeU BryanValverdeU BryanValverdeU approved these changes

@flyingbee2012 flyingbee2012 Awaiting requested review from flyingbee2012

@ianeli1 ianeli1 Awaiting requested review from ianeli1

@juliaroldi juliaroldi Awaiting requested review from juliaroldi

@Andres-CT98 Andres-CT98 Awaiting requested review from Andres-CT98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiuqingSong @BryanValverdeU