Customize merge model when paste #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
reviewed
Jul 31, 2023
| @@ -120,14 +125,19 @@ function createBeforePasteEvent( | |||
| }; | |||
| } | |||
|
|
|||
| function createFragmentFromClipboardData( | |||
| function createBeforePasteEventAndFragment( | |||
There was a problem hiding this comment.
Actually this fucntion does not only create event and fragment, but also trigger the event and let plugins handle it (same for the origianl code). So I think we need a better name.
There was a problem hiding this comment.
I renamed it to triggerPluginEventAndCreatePasteFragment and added a comment
JiuqingSong
reviewed
Jul 31, 2023
| PluginEventType.BeforePaste, | ||
| eventData, | ||
| true /* broadcast */ | ||
| ) as ContentModelBeforePasteEvent; |
There was a problem hiding this comment.
Is this type case required? Try remove it and see if it can pass the build.
There was a problem hiding this comment.
The build fails due a domToModelOption does not exist in BeforePasteEvent.
There was a problem hiding this comment.
hmm, that is a real problem
JiuqingSong
approved these changes
Jul 31, 2023
packages-content-model/roosterjs-content-model-editor/lib/publicApi/utils/paste.ts
Show resolved
Hide resolved
BryanValverdeU
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
customizedMergeto theContentModelBeforePasteEventDatainterface so can we use it as callback to change the way the copied fragment is merged to content model.Also, split the
getSelectedSegmentsfunctions from the other collect selections functions, so it can be exported.