Content Model Cache improvement 1: Create ContentModelCachePlugin #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
changed the title
JiuqingSong
changed the title
JiuqingSong
requested review from
BryanValverdeU,
juliaroldi,
flyingbee2012,
ianeli1,
vinguyen12 and
Andres-CT98
BryanValverdeU
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this series is to have a up-to-date Content Model stored in memory.
This is the first step, we create a new plugin
ContentModelCachePlugin, and move all cache related code into this plugin.ContentModelCachePlugincan be treated as a core plugin, it provides plugin state and will be stored as part ofEditorCoreso that core API can access it.Also move code of default format from
ContentModelEditPlugintoContentModelFormatPlugin, and move some other edit related contet out ofContentModelEditPluginto be standalone API to make the plugin code cleaner.