Standalone editor: Refactor list format handler 1 #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
requested review from
flyingbee2012,
BryanValverdeU,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
BryanValverdeU
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today list format handlers needs to decode/encode metadata when do DOM and Content Model conversion. This now happens in
roosterjs-content-model-dompackage. However we want to make this package only contains the core conversion code, but put the complex editing part toroosterjs-content-model-editorpackage. So I need to split out the metadata related code. Then the remaining code only read/write existing format styles but no need to do reformat (such as reapply list item number style)This is the first step, I did some code renaming to prepare for the next step, including:
ListStylePositionFormat=>ListStyleFormatContentModelFormatMap.listItem=>ContentModelFormatMap.listItemThreadAlso fix some minor bug in demo site buttons.