Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone Editor: Port event core API #2254

Merged
merged 70 commits into from
Dec 13, 2023
Merged

Standalone Editor: Port event core API #2254

merged 70 commits into from
Dec 13, 2023

Conversation

JiuqingSong
Copy link
Collaborator

@JiuqingSong JiuqingSong commented Dec 11, 2023

Port 2 event related core API to Standalone Editor:

  • attachDomEvent: To make it simpler, now this API only accept a map from event name to event handler object as parameter
  • triggerEvent

Then provide a new editor API in IStandaloneEditor:

  • attachDomEvent

The old API IEditor.addDomEventHandler will only appear in IEditor and IContentModelEditor, and is not recommended to use any more.

@JiuqingSong JiuqingSong merged commit 0f36271 into master Dec 13, 2023
7 checks passed
@JiuqingSong JiuqingSong deleted the u/jisong/eventapi branch December 13, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants