Update start of lists when pasting from Word Online #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
requested review from
flyingbee2012,
JiuqingSong,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
JiuqingSong
reviewed
Jan 17, 2024
| @@ -21,8 +23,16 @@ import type { | |||
| const LIST_ELEMENT_TAGS = ['UL', 'OL', 'LI']; | |||
| const LIST_ELEMENT_SELECTOR = LIST_ELEMENT_TAGS.join(','); | |||
|
|
|||
| const COMMENT_BG_COLOR_REST = 'rgba(209, 209, 209, 0.5)'; | |||
| const COMMENTS_TEXT_HIGHLIGHT_CLICKED = 'rgba(197, 139, 204, 0.5)'; | |||
| interface WacContext extends DomToModelContext { | |||
There was a problem hiding this comment.
Instead of extend DomToModelContext, can we extend its member listFormat (type DomToModelListFormat)?
There was a problem hiding this comment.
Sure, updated to extend DomToModelListFormat instead in the latest iteration.
JiuqingSong
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pasting multiple lists from Word Online to Rooster, if there are multiple numbering lists, the list start is not updated.
This PR adds functionality to update the start override of the level when needed. By checking the start attribute of the list.
This is because Word Online List content is most of the time provided like:
Since each of the list items are wrapped inside of ol/ul the list format is lost, because the default list processors remove the levels after processing each of the list element, so we need a custom behavior,
To do so, add:
Source:
