[Part 1] Port Auto Link #2479
Merged
[Part 1] Port Auto Link #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
JiuqingSong,
flyingbee2012,
BryanValverdeU,
ianeli1,
vinguyen12 and
Andres-CT98
JiuqingSong
reviewed
Mar 6, 2024
| @@ -1,7 +1,7 @@ | |||
| import { getObjectKeys } from 'roosterjs-content-model-dom'; | |||
|
|
|||
| /** | |||
| * @internal | |||
| * Data of the matched link | |||
| */ | |||
| export interface LinkData { | |||
There was a problem hiding this comment.
Move this to roosterjs-content-model-types/lib/parameters
JiuqingSong
reviewed
Mar 6, 2024
| @@ -27,6 +40,8 @@ export type AutoFormatOptions = { | |||
| const DefaultOptions: Required<AutoFormatOptions> = { | |||
| autoBullet: true, | |||
| autoNumbering: true, | |||
| autoUnlink: true, | |||
There was a problem hiding this comment.
Suggest set autoUnlink to false by default since we didn't use it
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private handleContentChangedEvent(editor: IEditor, event: ContentChangedEvent) { | ||
| const { autoLink } = this.options; |
There was a problem hiding this comment.
The original auto link feature also work when press SPACE or ENTER
There was a problem hiding this comment.
I see you put it in part 2. that is ok.
JiuqingSong
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port
AutoLinkandUnlinkWhenBackspaceAfterLinkcontent edit features intoAutoFormatPluginAfter porting
AutoLink,AutoFormatPluginwill handle automatically create link from pasted url segments, and after portingUnlinkWhenBackspaceAfterLink, will automatically remove the link of text segment, if backspace key is pressed when the cursor is after a link.Another PR will be created to handle AutoLink while typing.