[Part 2] Port Auto link #2485
Merged
[Part 2] Port Auto link #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
flyingbee2012,
BryanValverdeU,
vinguyen12 and
Andres-CT98
JiuqingSong
reviewed
Mar 7, 2024
Comment on lines
8
to
10
| if (!unlink) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
why need this parameter? If unlink is false, we should not call this function at all
Comment on lines
8
to
10
| */ | ||
| export function createLinkAfterSpace(editor: IEditor, autoLink: boolean) { | ||
| if (!autoLink) { |
| @@ -5,7 +5,10 @@ import type { IEditor } from 'roosterjs-content-model-types'; | |||
| /** | |||
| * @internal | |||
| */ | |||
| export function createLink(editor: IEditor) { | |||
| export function createLink(editor: IEditor, autoLink: boolean) { | |||
| if (!autoLink) { | |||
JiuqingSong
reviewed
Mar 8, 2024
| triggerList(editor, model, listType, styleType, index); | ||
| rawEvent.preventDefault(); | ||
| normalizeContentModel(model); | ||
| if (shouldSearchForBullet || shouldSearchForNumbering) { |
There was a problem hiding this comment.
same here, check outside to reduce unnecessary parameters.
There was a problem hiding this comment.
We already use these parameter on line 20 and 21, then we cannot remove them
There was a problem hiding this comment.
Should I return this check to outside the function anyway?
There was a problem hiding this comment.
I see. In that case we can keep it
JiuqingSong
approved these changes
Mar 8, 2024
| triggerList(editor, model, listType, styleType, index); | ||
| rawEvent.preventDefault(); | ||
| normalizeContentModel(model); | ||
| if (shouldSearchForBullet || shouldSearchForNumbering) { |
There was a problem hiding this comment.
I see. In that case we can keep it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of the effort to port the Auto Link from the legacy ContentEdit feature into
AutoFormatPlugin. After this changeAutoFormatPluginwill automatically transform a typed url when space key is pressed after the text segment.