-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FHL: Port TableCellSelection plugin #2506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
requested review from
BryanValverdeU,
flyingbee2012,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
March 18, 2024 18:56
…osoft/roosterjs into u/jisong/porttableselection
This behaviour appears to be missing from the port: #2024 |
Thanks, good catch! Just fixed. |
BryanValverdeU
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the original
TableCellSelection
plugin and merge the logic into existingSelectionPlugin
. Now the table selection become part of editor core, and no need to add any plugin explicitly for it.Expose the following new types:
Create the following internal util functions:
Add a
IgnoredPluginNames
const inEditorAdapter
to aways ignore oldTableCellSelection
plugin since it will be conflict with the new oneAlso handle keyboard event for the following cases:
I didn't handle TAB key in this change since it is not directly related to table selection. We will handle it in future changes.
Fix a bug in
getDOMSelection
when check isReverted.Fix #861