[FHL] Import model document #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
JiuqingSong,
flyingbee2012,
BryanValverdeU,
ianeli1,
vinguyen12 and
Andres-CT98
| ).then(values => { | ||
| const importedModel = JSON.parse(values.model) as ContentModelDocument; | ||
| editor.formatContentModel(model => { | ||
| if (importedModel) { |
There was a problem hiding this comment.
nit: Could we also add a type check to make sure the imported model contains blocks?
| undefined /* onChange */, | ||
| 10 /* rows */ | ||
| ).then(values => { | ||
| const importedModel = JSON.parse(values.model) as ContentModelDocument; |
There was a problem hiding this comment.
nit: JSON.parse can throw if we set the content that is not in JSON format. Maybe we can wrap all this function in a try catch
…oft/roosterjs into u/juliaroldi/import-model
BryanValverdeU
approved these changes
Mar 18, 2024
JiuqingSong
reviewed
Mar 18, 2024
| if (isBlockGroupOfType(importedModel, 'Document')) { | ||
| editor.formatContentModel(model => { | ||
| model.blocks = importedModel.blocks; | ||
| return true; |
There was a problem hiding this comment.
let's also copy format from imported model.
…oft/roosterjs into u/juliaroldi/import-model
JiuqingSong
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Import Button" control. This feature replaces the actual content-model with another model input by user.
