-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tabs to demo site and PresetPlugin #2511
Conversation
… u/acampostams/demo-tabs-and-presets
…u/acampostams/demo-tabs-and-presets
…u/acampostams/demo-tabs-and-presets
switch (event.eventType) { | ||
case 'editorReady': | ||
case 'contentChanged': | ||
this.updatePresetPluginState(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to update editor for ContentChanged event. Just do it for EditorReady should be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to do it to update the CSS of the selected Preset button.
Description:
The demo site has only one ribbon which contains all buttons on it. This makes it hard to debug, as well as general demo site usage, when constantly using the buttons that exist only on the expanded ribbon. Here is an example of the full workflow of creating a 3x3 table and making its central cell red with thick borders:
Fix
Tabs
Created tabs that modify which buttons show up on the ribbon, as well as making some common use buttons permanently accessible outside the ribbon. The old ribbon is still the default one under the Main tab. Here is the previous workflow under the new system:
The buttons made accessible outside the ribbon are: Undo, Redo, Zoom, Dark mode toggle, Export model, and Pop out window.
Presets
To improve the workflow even more, a preset plugin was implemented so that common use cases, or uncommon ones useful for testing, can be accessed at the press of a button and persist on page reloads.
Miscellaneous changes
Warnings and implications
Made during FHL Week