Fix Table Edit plugin tests #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
reviewed
May 30, 2024
packages/roosterjs-content-model-plugins/lib/tableEdit/editors/features/CellResizer.ts
Outdated
Show resolved
Hide resolved
packages/roosterjs-content-model-plugins/lib/tableEdit/editors/features/CellResizer.ts
Outdated
Show resolved
Hide resolved
….com/microsoft/roosterjs into u/acampostams/fix-table-plugin-tests
JiuqingSong
reviewed
May 30, 2024
| } | ||
| return !!inserter ? 'found' : 'not found'; | ||
| //Act | ||
| div.click(); |
There was a problem hiding this comment.
nit: Not something we must fix but want to bring up. We can also consider not use something like "element.click()" but instead we directly call the click handler function so we don't need to rely on the browser's event routing.
JiuqingSong
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamped tests for Table Edit Plugin to not use mouse events and reorganised some tests.
The following changes were made for testing:
Also renamed the Context and Initvalue interfaces for CellResizer and TableResizer.