Auto format trigger #2684
Merged
Auto format trigger #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
flyingbee2012,
BryanValverdeU,
JiuqingSong,
ianeli1,
vinguyen12 and
Andres-CT98
| ); | ||
| if (formatOptions.changeSource) { |
There was a problem hiding this comment.
What if instead of triggering another plugin event here we change the formatWithContentModel implementation by moving line 27
(Or at least the ChangeSource and ApiName properties destructing declaration) before line 81 but after calling the formatter callback
Since the option object is destructed to get the values before the callback and we modify the options object in the format callback the AutoFormat Change source is not correctly set.
@JiuqingSong to check if this is okay.
There was a problem hiding this comment.
Thanks, @BryanValverdeU!! That worked out better that my solution.
JiuqingSong
approved these changes
Jun 6, 2024
BryanValverdeU
approved these changes
Jun 6, 2024
BryanValverdeU
added a commit
that referenced
this pull request
Jun 6, 2024
* Merge Link & Image Format when using MergeModel (#2681) * mergeLinkFormat * Also fix for images * remove unneeded changes * Remove more unneeded changes * Address comment * nit --------- Co-authored-by: Jiuqing Song <jisong@microsoft.com> * update versions * Merge pull request #2684 from microsoft/u/juliaroldi/trigger-auto-format Auto format trigger --------- Co-authored-by: Jiuqing Song <jisong@microsoft.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger event Auto format event in AutoFormatPlugin, so we can trigger the AutoFormat UI on OWA.
