Word "constructor" should not trigger auto list #2690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To repro:
Expect: nothing special happens
Actual: it converts "constructor" into a list with text "function Object() { [native code] } "
This is because we have code like this:
If input is some predefined property name such as "constructor", "valueOf", "toString", it will return a function object which is treated as a valid result, which should not.
Fix: use Map instead of Record here.
Future work: Check all other places where Record is used. Possibly find a eslint rule to disable it at all.