Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context menu for Image Edit menu #2726

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Fix context menu for Image Edit menu #2726

merged 7 commits into from
Jun 26, 2024

Conversation

juliaroldi
Copy link
Contributor

To make context menu work with image edit plugin, when the user right clicks on an image, the editing operations will be applied, and the image will be selected. Also, if the image was selected and right click occurs in an element that is not a image, remove image selection.
ContextMenuOnImages

@BryanValverdeU
Copy link
Contributor

Hey Julia, I think this looks good. is Shift + F10 to open the context menu should also be supported?

@juliaroldi
Copy link
Contributor Author

Hey Julia, I think this looks good. is Shift + F10 to open the context menu should also be supported?

I didn't test it, at least for mac, this shortcut controls volume

@BryanValverdeU
Copy link
Contributor

Hey Julia, I think this looks good. is Shift + F10 to open the context menu should also be supported?

I didn't test it, at least for mac, this shortcut controls volume

I see for Window it also triggers the context menu.

@juliaroldi
Copy link
Contributor Author

Hey Julia, I think this looks good. is Shift + F10 to open the context menu should also be supported?

I didn't test it, at least for mac, this shortcut controls volume

I see for Window it also triggers the context menu.

It will not trigger, because only modifier key selects the image, let me add shift to select the image too

@BryanValverdeU
Copy link
Contributor

Shift + F10 is working now:
Fixed

@juliaroldi juliaroldi merged commit a69e21a into master Jun 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanValverdeU BryanValverdeU BryanValverdeU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliaroldi @BryanValverdeU