Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only dismiss the Table Mover if the end of the drag is not in the Table Mover div #2727

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

BryanValverdeU
Copy link
Contributor

@BryanValverdeU BryanValverdeU commented Jun 24, 2024

The Table Mover feature is incorrectly dismissed when only clicking it. To fix do not dismiss the table mover if the target on drag end target is not the div containing the Table mover.

Before (Notice that on click the mouse cursor is set to arrow because the table mover element got detached.)
TableMoverBefore

After
TableMoverAfter

@BryanValverdeU BryanValverdeU changed the title Only dismiss the Table Mover if the end of the drag is not in the Feature Handler Only dismiss the Table Mover if the end of the drag is not in the Table Mover div Jun 24, 2024
Copy link
Contributor

@Andres-CT98 Andres-CT98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine. I was worried that maybe not disposing it would cause a potential double Table Mover, but we did already have a check preventing that.

@BryanValverdeU BryanValverdeU merged commit bddd1d9 into master Jun 25, 2024
7 checks passed
@BryanValverdeU BryanValverdeU deleted the u/bvalverde/tableMover2 branch June 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants