Fix #2734 by Setting List Metadata applyListStyleFromLevel: true when toggling a list
#2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
requested review from
flyingbee2012,
JiuqingSong,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
juliaroldi
reviewed
Jul 11, 2024
| if (level) { | ||
| updateListMetadata(level, metadata => | ||
| Object.assign({}, metadata, { | ||
| applyListStyleFromLevel: true, |
There was a problem hiding this comment.
besides here, when do we set this metadata to true?
There was a problem hiding this comment.
The other place we set this metadata is when indenting a List. In setModelIndentation.ts
There was a problem hiding this comment.
Ok, I tested, and I did not find any regressions.
juliaroldi
approved these changes
Jul 11, 2024
| if (level) { | ||
| updateListMetadata(level, metadata => | ||
| Object.assign({}, metadata, { | ||
| applyListStyleFromLevel: true, |
There was a problem hiding this comment.
Ok, I tested, and I did not find any regressions.
|
This will also fix #2735 |
ianeli1
added a commit
that referenced
this pull request
Jul 15, 2024
* Export DefaultSanitizers to be available in roosterjs-content-model-plugins package #2739 * Fix #2741 by changing Id selectors from `#{id}` to `[id="{id}"]` (#2742) * init * Fix build * fix selection * fix * fixes * remove console.log * fix test * Fix #2734 by Setting List Metadata `applyListStyleFromLevel: true` when toggling a list (#2743) * init * Tests * add missing file * crop alternative * Fix #2733 by changing the approach to announce repeated announce messages (#2745) * init * move string to constant * bump version --------- Co-authored-by: vhuseinova-msft <98852890+vhuseinova-msft@users.noreply.github.com> Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com> Co-authored-by: Julia Roldi (from Dev Box) <juliaroldi@microsoft.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #2734.
Right now, we do not set metadata when toggling a numbering or bullet list.
This causes getListAnnounceData to return undefined, so when using Enter on a List we do not announce anything.
To fix, always set the applyListStyleFromLevel metadata so we announce the new list item marker.
To test:
Before
No announcing of the new list item
After
We announce the new list item marker.