Create getSafeIdSelector and replace all Id selectors with it. #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanValverdeU
requested review from
flyingbee2012,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
juliaroldi
approved these changes
Jul 17, 2024
juliaroldi
pushed a commit
that referenced
this pull request
Jul 18, 2024
* init * Add other occurence
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous change #2742 I updated an Id selector to use
[id='']instead of#id, to prevent some issues in Native Browser APIs. but it looks like more places in the repo require this change.To have a single util for this created getSafeIdSelector, so if the id starts with
number,-or_use[id={}]selector instead of#id. and updated some places in the app to use this util.