[rush] Fix 1347 by resolving paths to local projects by referring to the shrinkwrap #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinjoseph
requested review from
apostolisms,
halfnibble,
iclanton,
Lincoded and
octogonz
as code owners
sachinjoseph
changed the title
sachinjoseph
changed the title
halfnibble
approved these changes
Jul 10, 2019
iclanton
requested changes
Jul 10, 2019
Co-Authored-By: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Co-Authored-By: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
sachinjoseph
force-pushed
the
sachinjoseph/fix1347
branch
from
b5e2609
to
b3900a9
Compare
iclanton
reviewed
Jul 10, 2019
iclanton
approved these changes
Jul 10, 2019
|
Make sure you test this pretty extensively. |
@iclanton I tested this on wbt, sp-client, and the repro repo in #1347, https://github.com/imodeljs/imodeljs, on pnpm 2 and pnpm 3. Do you suggest any other test repos? I am not completely familiar with the feature so it's possible that I am missing some edge cases. |
sachinjoseph
force-pushed
the
sachinjoseph/fix1347
branch
from
4c0fd14
to
18c6d46
Compare
|
I think you're good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rush linkwas failing on pnpm 3+ with the changes in shrinkwrap format with regard to peer dependencies. Rush now resolves paths to local projects accurately by referring to the shrinkwrap rather than figuring out the path on its own. See #1347.