Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding release-it configuration with workspaces publishing support #2

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

scalvert
Copy link
Collaborator

@scalvert scalvert commented Mar 23, 2021

Depends on #1

Adds release-it and associated configuration for yarn workspaces via create-rwjblue-release-it-setup.

Note: we're using the release-it-yarn-workspaces plugin even though we use npm in this repository. That plugin works with npm, and will ultimately be renamed to the more generic release-it-workspaces to correctly signify generic workspaces support.

@scalvert
Copy link
Collaborator Author

cc/ @jeffersonking

@scalvert scalvert marked this pull request as draft March 23, 2021 18:13
@scalvert scalvert changed the title Repository infrastructure setup Adding release-it configuration Mar 24, 2021
@scalvert scalvert marked this pull request as ready for review March 24, 2021 20:33
@@ -1,12 +1,12 @@
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The create-rwjblue-release-it-setup package uses sort-package-json, which is why this file now appears sorted in spite of minimal changes.

@scalvert scalvert changed the title Adding release-it configuration Adding release-it configuration with workspaces publishing support Mar 24, 2021
@scalvert scalvert force-pushed the add-release-it branch 2 times, most recently from ba6008d to 5048cb7 Compare March 24, 2021 23:35
@scalvert scalvert marked this pull request as draft March 27, 2021 00:00
@scalvert
Copy link
Collaborator Author

Converting this to a draft for now while @eddynaka investigates requirements for publishing.

@scalvert scalvert changed the title Adding release-it configuration with workspaces publishing support WIP: Adding release-it configuration with workspaces publishing support Mar 27, 2021
@eddynaka
Copy link
Contributor

Converting this to a draft for now while @eddynaka investigates requirements for publishing.

Quick update on this:

  • started a pr with codeql
  • integrated with LGTM

Internally people run eslint. Should we run as well?

@scalvert
Copy link
Collaborator Author

@eddynaka since our github actions run eslint code should not be able to be merged in a PR without that passing. We could additionally run lint checks before a release, but it does seem redundant. If we're concerned about folks pushing to main and circumventing this, we could make main a protected branch, which would require anyone committing anything to be forced down the PR/actions pipeline.

WDYT?

@eddynaka
Copy link
Contributor

@eddynaka since our github actions run eslint code should not be able to be merged in a PR without that passing. We could additionally run lint checks before a release, but it does seem redundant. If we're concerned about folks pushing to main and circumventing this, we could make main a protected branch, which would require anyone committing anything to be forced down the PR/actions pipeline.

WDYT?

no worries. I wasn't sure if we were already running. thanks for answering :)

@eddynaka
Copy link
Contributor

eddynaka commented Apr 3, 2021

@scalvert , I checked internally and everything that we set-up so far is good enough (CodeQL, LGTM, and ESLint).
We can continue this pr :)

@scalvert scalvert marked this pull request as ready for review April 13, 2021 15:50
@scalvert
Copy link
Collaborator Author

@eddynaka thanks for looking into it!

@scalvert scalvert changed the title WIP: Adding release-it configuration with workspaces publishing support Adding release-it configuration with workspaces publishing support Apr 14, 2021
@scalvert scalvert deleted the add-release-it branch April 19, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants