-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding release-it configuration with workspaces publishing support #2
Conversation
cc/ @jeffersonking |
84e2912
to
9c256ac
Compare
@@ -1,12 +1,12 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The create-rwjblue-release-it-setup
package uses sort-package-json
, which is why this file now appears sorted in spite of minimal changes.
ba6008d
to
5048cb7
Compare
Converting this to a draft for now while @eddynaka investigates requirements for publishing. |
Quick update on this:
Internally people run eslint. Should we run as well? |
@eddynaka since our github actions run eslint code should not be able to be merged in a PR without that passing. We could additionally run lint checks before a release, but it does seem redundant. If we're concerned about folks pushing to main and circumventing this, we could make main a protected branch, which would require anyone committing anything to be forced down the PR/actions pipeline. WDYT? |
no worries. I wasn't sure if we were already running. thanks for answering :) |
@scalvert , I checked internally and everything that we set-up so far is good enough (CodeQL, LGTM, and ESLint). |
@eddynaka thanks for looking into it! |
2c62c05
to
cc501fd
Compare
Depends on #1Adds
release-it
and associated configuration for yarn workspaces viacreate-rwjblue-release-it-setup
.Note: we're using the
release-it-yarn-workspaces
plugin even though we usenpm
in this repository. That plugin works withnpm
, and will ultimately be renamed to the more genericrelease-it-workspaces
to correctly signify generic workspaces support.