Add additional thread-safety guarantees to Cache class. (#2306)

Co-authored-by: Eddy Nakamura <eddynaka@gmail.com>
microsoft · Mar 3, 2021 · 46b26e5 · 46b26e5
1 parent 19b010c
commit 46b26e5
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/Sarif/Cache.cs b/src/Sarif/Cache.cs
@@ -103,16 +103,22 @@ private void SetValue(TKey key, TValue value)
         /// <returns>True if value in cache, False otherwise</returns>
         public bool ContainsKey(TKey key)
         {
-            return _cache.ContainsKey(key);
+            lock (_keysInUseOrder)
+            {
+                return _cache.ContainsKey(key);
+            }
         }
 
         /// <summary>
         /// Clear current cache.
         /// </summary>
         public void Clear()
         {
-            this._cache.Clear();
-            this._keysInUseOrder.Clear();
+            lock (_keysInUseOrder)
+            {
+                this._cache.Clear();
+                this._keysInUseOrder.Clear();
+            }
         }
     }
 }