Fix Sarif.Driver and Sarif.Functional tests. (#1217)

* Fix Sarif.Driver and Sarif.Functional tests. * Restore test file
microsoft · Jan 16, 2019 · 5af4079 · 5af4079
1 parent 5e62a20
commit 5af4079
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Sarif.Converters/AndroidStudioConverter.cs b/src/Sarif.Converters/AndroidStudioConverter.cs
@@ -82,7 +82,7 @@ public override void Convert(Stream input, IResultLogWriter output, OptionallyEm
         /// </returns>
         private IList<Result> ProcessAndroidStudioLog(XmlReader xmlReader)
         {
-            var results = new List<Result>();
+            var results = new HashSet<Result>(Result.ValueComparer);
 
             int problemsDepth = xmlReader.Depth;
             xmlReader.ReadStartElement(_strings.Problems);
@@ -98,7 +98,7 @@ private IList<Result> ProcessAndroidStudioLog(XmlReader xmlReader)
 
             xmlReader.ReadEndElement(); // </problems>
 
-            return results;
+            return new List<Result>(results);
         }
 
         public Result ConvertProblemToSarifResult(AndroidStudioProblem problem)

diff --git a/src/Sarif.Driver.UnitTests/SimpleTestRule.cs b/src/Sarif.Driver.UnitTests/SimpleTestRule.cs
@@ -12,7 +12,7 @@ namespace Microsoft.CodeAnalysis.Sarif
     [Export(typeof(IRule)), Export(typeof(IOptionsProvider)), Export(typeof(ISkimmer<TestAnalysisContext>))]
     internal class SimpleTestRule : TestRuleBase, IOptionsProvider
     {
-        public new string Id => "TEST002";
+        public override string Id => "TEST002";
 
         public override Message FullDescription { get { return new Message { Text = String.Empty }; } }