Skip to content

Commit

Permalink
Fix #2089: GitHub policy should not turn off any note level rules (#2096
Browse files Browse the repository at this point in the history 
)

* Fix #2089: GitHub policy should not turn off any note level rules

* Elevate two rules and (correctly) disable one.

* Update release history.

Co-authored-by: Larry Golding <lgolding@comcast.net>
Co-authored-by: Michael C. Fanning <michael.fanning@microsoft.com>
  • Loading branch information
@michaelcfanning
3 people authored Oct 15, 2020
1 parent e57c5ff commit a79bc8e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 42 deletions.
45 changes: 3 additions & 42 deletions policies/github.config.xml
View file
Original file line number Diff line number Diff line change
@@ -1,51 +1,12 @@
<?xml version="1.0" encoding="utf-8"?>
<Properties>
<Properties Key='SARIF2001.TerminateMessagesWithPeriod.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2002.ProvideMessageArguments.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2003.ProvideVersionControlProvenance.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2004.OptimizeFileSize.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2005.ProvideToolProperties.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2006.UrisShouldBeReachable.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2007.ExpressPathsRelativeToRepoRoot.Options'>
<!-- Upgraded from Warning. -->
<!-- Upgraded from Warning, because GitHug requires this. -->
<Property Key='RuleEnabled' Value='Error' />
</Properties>
<Properties Key='SARIF2008.ProvideSchema.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2009.ConsiderConventionalIdentifierValues.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2010.ProvideCodeSnippets.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2011.ProvideContextRegion.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2012.ProvideHelpUris.Options'>
<!-- Because GitHub displays them if available. -->
<Property Key='RuleEnabled' Value='Error' />
</Properties>
<Properties Key='SARIF2013.ProvideEmbeddedFileContent.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2014.ProvideDynamicMessageContent.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
</Properties>
<Properties Key='SARIF2015.EnquoteDynamicMessageContent.Options'>
<Property Key='RuleEnabled' Value='Disabled' />
<!-- Upgraded from Note, because GitHub displays them if available. -->
<Property Key='RuleEnabled' Value='Warning' />
</Properties>
<Properties Key='SARIF2016.FileUrisShouldBeRelative.Options'>
<!-- Not necessary because SARIF2007.ExpressPathsRelativeToRepoRoot is stricter. -->
Expand Down
1 change: 1 addition & 0 deletions src/ReleaseHistory.md
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# SARIF Package Release History (SDK, Driver, Converters, and Multitool)

## **v2.3.7** [Sdk](https://www.nuget.org/packages/Sarif.Sdk/2.3.7) | [Driver](https://www.nuget.org/packages/Sarif.Driver/2.3.7) | [Converters](https://www.nuget.org/packages/Sarif.Converters/2.3.7) | [Multitool](https://www.nuget.org/packages/Sarif.Multitool/2.3.7) | [Multitool Library](https://www.nuget.org/packages/Sarif.Multitool.Library/2.3.7)
* BUGFIX: GitHub policy should not turn off any note level rules. [#2089](https://github.com/microsoft/sarif-sdk/issues/2089)
* FEATURE: Add a converter for FlawFinder's CSV output format.
* DEPENDENCY BREAKING: SARIF now requires Newtonsoft.JSON 11.0.2 (rather than 10.0.3)
* DEPENDENCY: SARIF TypeScript package now requires minimist 1.2.3 or later (rather than >=1.2.0)
Expand Down

0 comments on commit a79bc8e

Please sign in to comment.