Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get v2 -> v1 transform working with files array #1211

Merged
12 commits merged into from
Jan 14, 2019
Merged

Get v2 -> v1 transform working with files array #1211

12 commits merged into from
Jan 14, 2019

Commits on Jan 13, 2019

  1. Create v1 files dictionary in simple case.

    Larry Golding committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    7139747 View commit details
    Browse the repository at this point in the history

  2. Get response file content working; fixes one test.

    Larry Golding committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    f79fe68 View commit details
    Browse the repository at this point in the history

  3. Don't repeat fileData.uri if it matches the dictionary key.

    Larry Golding committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    622c2ab View commit details
    Browse the repository at this point in the history

  4. Extract CreateFileDictionaryKey method; dummy implementation.

    Larry Golding committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    d5f9620 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Synthesize file dictionary keys for nested files.

    Larry Golding committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    1c9c6a0 View commit details
    Browse the repository at this point in the history

  2. Compute parent key; this gets another test working. 

    ... but OneRunWithBasicInvocation regressed.
    Larry Golding committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    c16f1f4 View commit details
    Browse the repository at this point in the history

  3. Fix OneRunWithBasicInvocation. 

    The output was actually correct. The converter now, as permitted by the v1 spec, omits file.uri if it matches the key.
    Larry Golding committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    e3a51ca View commit details
    Browse the repository at this point in the history

  4. Get last unit test working 

    ... but there is still commented out code, showing that we have test holes.
    Larry Golding committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    718a420 View commit details
    Browse the repository at this point in the history

  5. Incorporate PR feedback.

    Larry Golding committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    43a85cd View commit details
    Browse the repository at this point in the history

  6. Bug fix: don't insert double slashes in multiply nested paths.

    Larry Golding committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    49ebc34 View commit details
    Browse the repository at this point in the history

  7. Move towards compatibility with FileDiffingTests helper method.

    Larry Golding committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    3fb517d View commit details
    Browse the repository at this point in the history

  8. SarifCurrentToVersionOneVisitorTests use helper from base class.

    Larry Golding committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    ee8c807 View commit details
    Browse the repository at this point in the history