Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement v2->v1 conversion for rules dictionary #1228

Merged
11 commits merged into from
Jan 22, 2019
Merged

Implement v2->v1 conversion for rules dictionary #1228

11 commits merged into from
Jan 22, 2019

Commits on Jan 21, 2019

  1. Schema: run.results not unique; add notification.ruleIndex.

    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    76feeec View commit details
    Browse the repository at this point in the history

  2. Schema: Fix version number in title.

    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    0f346de View commit details
    Browse the repository at this point in the history

  3. Set up OneRuleWithRules test to fail.

    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    be72499 View commit details
    Browse the repository at this point in the history

  4. Populate v1 ruleId.

    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    c82cd69 View commit details
    Browse the repository at this point in the history

  5. Fix tests: Don't adjust level "open" until rules is an array.

    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    841b088 View commit details
    Browse the repository at this point in the history

  6. Synthesize keys on rule id

    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    46c273d View commit details
    Browse the repository at this point in the history

  7. Construct v1 rules dictionary; "OneRunWithRules" test passes.

    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    8ab228c View commit details
    Browse the repository at this point in the history

  8. Get TwoResultsWithFixes test working 

    PreRelCompatTrans loses the rules dictionary key, so we shouldn't expect it in the output.
    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    21c4f9b View commit details
    Browse the repository at this point in the history

  9. Rebaseline one test to avoid spurious file ordering difference.

    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    e2ce115 View commit details
    Browse the repository at this point in the history

  10. Add a comment.

    Larry Golding committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    713f359 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Incorporate PR feedback.

    Larry Golding committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    f66d0b2 View commit details
    Browse the repository at this point in the history