Fix #1673 (property bag testing); Fix #1687 (NuGet packaging warning) #1688
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Copyright (c) Microsoft. All rights reserved. Licensed under the MIT | ||
| // license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using FluentAssertions; | ||
| using Newtonsoft.Json; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Sarif | ||
| { | ||
| public class RoundTrippingTests | ||
| { | ||
| private static ResourceExtractor s_extractor = new ResourceExtractor(typeof(RoundTrippingTests)); | ||
|
|
||
| private static string GetResourceContents(string resourceName) | ||
| => s_extractor.GetResourceText($"RoundTripping.{resourceName}"); | ||
|
|
||
| [Fact] | ||
| public void SarifLog_CanBeRoundTripped() | ||
| { | ||
| string originalContents = GetResourceContents("RoundTripping.sarif"); | ||
|
|
||
| SarifLog log = JsonConvert.DeserializeObject<SarifLog>(originalContents); | ||
|
|
||
| string roundTrippedContents = JsonConvert.SerializeObject(log, Formatting.Indented); | ||
|
|
||
| roundTrippedContents.Should().Be(originalContents); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "$schema": "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0-rtm.4.json", | ||
| "version": "2.1.0", | ||
| "runs": [ | ||
| { | ||
| "tool": { | ||
| "driver": { | ||
| "name": "Bug1673Tester" | ||
| } | ||
| }, | ||
| "results": [ | ||
| { | ||
| "ruleId": "TST0001", | ||
| "message": { | ||
| "text": "Hello." | ||
| }, | ||
| "properties": { | ||
| "date": "2019-09-25T15:07Z", | ||
| "string": "Hello, string!", | ||
| "integer": 42, | ||
| "bigInteger": 5000000000, | ||
| "true": true, | ||
| "false": false, | ||
| "dateArray": [ | ||
| "2019-09-26T15:52Z", | ||
| "2019-09-26T15:54Z" | ||
| ], | ||
| "stringArray": [ | ||
| "Thing One", | ||
| "Thing Two" | ||
| ], | ||
| "customObject": { | ||
| "date": "1776-07-04T12:00Z", | ||
| "string": "The 4th" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "columnKind": "utf16CodeUnits" | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how
Formatting.Indentedrenders the arrays and sub-objects withinproperties. I don't know why. #ByDesignThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's because the
PropertyBagConverterhas taken over the serialization at this point and it doesn't retain the indentation.In reply to: 328869713 [](ancestors = 328869713)