Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a couple of edge-cases that cause the ESLint formatter to create invalid SARIF files #2068

Merged
4 commits merged into from
Sep 14, 2020
Merged

Fixing a couple of edge-cases that cause the ESLint formatter to create invalid SARIF files #2068

4 commits merged into from
Sep 14, 2020

Commits on Sep 9, 2020

  1. Only adding shortDescription to a rule if a description exists 

    Otherwise the output is an invalid SARIF file with a missing text field
    Chris Raynor committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    0f5a635 View commit details
    Browse the repository at this point in the history

  2. Adding test for valid SARIF from a custom rule with no description

    Chris Raynor committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    e147c70 View commit details
    Browse the repository at this point in the history

  3. Only adding startLine / startColumn if they are > 0

    Chris Raynor committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    a7aa894 View commit details
    Browse the repository at this point in the history

  4. Adding test for invalid column number

    Chris Raynor committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    e67691a View commit details
    Browse the repository at this point in the history