Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling error in rtm.5 schema #2426

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

EasyRhinoMSFT
Copy link
Collaborator

This change results in updated auto-generated model classes and also touches a handful of functional test data.

@@ -591,13 +591,13 @@
},

"guid": {
"description": "A stable, unique identifer for this external properties object, in the form of a GUID.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identifer

is it right to make changes to a schema that is already published? not sure how the flow works.

i saw that is only english word changes, but not sure if that is correct or not

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow rtm.5 was published without this misspelling. We decided to think of this as a change to bring the published and checked-in schemas into sync, and would therefore not create a new version.

@michaelcfanning michaelcfanning merged commit 64a4b7e into main Jan 27, 2022
@michaelcfanning michaelcfanning deleted the rtm5-schema-spelling branch January 27, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants