HdfConverter: map status to SARIF kind/level/rank correctly (#2695) #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rank should only be output when kind=fail * level should only be output when kind=fail * handle kind values of passed, faild, error, and skipped Signed-off-by: Craig Andrews <candrews@integralblue.com>
michaelcfanning
requested review from
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
|
OK, I see you're already a contributor! :) In future, if your want to branch off main and create PRs that way, please feel free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@candrews, I created this PR directly against main as our ADO infrastructure won't run against a fork, for security reasons. I will approve and this will get merged as soon as tests pass.
As I recall, your account will be associated with this merge, as it originates with your fork. Thanks for the contribution! I have added your as a contributor to the repo: in future if you'd like to update this code, please feel free to branch directly off main.