-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement smart validation in SarifCli tool #501
Merged
Merged
Changes from 25 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
7faaf3d
Implement smart validation in SarifCli tool
ebb4a4c
Revert an accidental change to a .csproj file
302d02f
SarifCli: Minor cleanups
bf4b015
Fix appVeyor build break
046c98f
SarifCli: Get JSchema/JPointer from NuGet, not FCIB
d6de920
Sarif.ValidationTests: Get JSchema from NuGet, not FCIB
00a6e30
Upgrade ToDotNet.targets to JSchema.ToDotNet 0.45.0
c1e2261
Remove FCIBs; Microsoft.Json.* now come from NuGet
2110f95
Add SarifCli.FunctionalTests to appveyor.yml
a80c8d9
Refactor: Move HelpUri to SkimmerBase, rename RuleIds => RuleId
d241fa0
Refactor: Make Context a protected property of SkimmerBase
3316b0a
Refactor: Move visiting logic into SkimmerBase
b1da0ed
Refactor: Move result construction to SkimmerBase
2da17d4
Refactor: Rename SkimmerBase.Visit to Analyze
06a904a
Refactor: Extract Visit method; remove unneeded properties
7d6ccdd
Refactor: Extract Visit(Run), decompose pointer construction
e03e8e9
Bug fix: Command line broken: can't find System.Composition.Hosting
a518291
SarifCli: Visit results (prep for the next skimmer)
2a7ca77
SarifCli: Start of UseAbsolutePathsForNestedFileUriFragments skimmer
4918d39
UseAbsolutePathsForNestedFileUriFragments checks location.resultFile.uri
b73be17
SarifCli: Include the JSON pointer in each message
d46055f
UseAbsolutePathsForNestedFileUriFragments handles result.relatedLocat…
7666936
UseAbsolutePathsForNestedFileUriFragments handles codeFlow URIs
075284c
UseAbsolutePathsForNestedFileUriFragments handles stack frame URIs
eb59c47
UseAbsolutePathsForNestedFileUriFragments handles notification analys…
85cf6c5
Refactor: DRY out UseAbsolutePathsForNestedFileUriFragments
6c12eee
Refactor: SarifCli: DRY out tool and configuration notification handling
dadefdf
UseAbsolutePathsForNestedFileUriFragments handles fileChange URIs
02aff1f
SarifCli: Remove unnecessary elements from test files
bd6596b
SarifCli: Implement UriValuedPropertiesAreValidUris and AnnotatedCode…
6a77b70
SarifCli: Implement HashAlgorithmsMustBeUnique rule
714ef3a
SarifCli: Implement EndTimeMustBeAfterStartTime
255ad4f
SarifCli: Remove "Diagnostic" from test names; use DisplayName
4dd64a8
SarifCli: Implement AnnotatedCodeLocationEssentialIsObsolete rule
372554e
Bug fix: Don't run skimmers if log has a syntax error
0f7d0d2
Bug fix: Don't run skimmers if log can't be deserialized
b2e999c
Bug fix: Tests failed because of misnamed test files
1445d1c
Bug fix: Missed presence of default value for aCL.essential
caf7d82
Implement MessagesShouldEndWithPeriod rule
0d70945
Implement StepMustIncreaseByOneFromOne (NotPresentOnAll)
78d9a5e
StepValuesMustFormOneBasedSequence (InvalidStepValue)
0466ffe
SarifCli: Implement StepMustAppearOnlyInCodeFlowLocations rule
88602d8
SarifCli: Implement ImportanceMustAppearOnlyInCodeFlowLocations rule
6d2129d
SarifCli: Refactor: Introduce HasProperty extension method
ddaaf13
SarifCli: Implement EndLineMustNotBeLessThanStartLine rule
0e40898
SarifCli: Refactor: Introduce ToInvariantString
9e6ea5a
SarifCli: Implement EndColumnMustNotBeLessThanStartColumn rule
fbd4bbf
Merge branch 'master' into smart-validator
e8b143b
Merge branch 'master' into smart-validator
3197e82
For some reason Autogenerated/TaintKind.cs had wrong version
c83acff
Upgrade to SARIF 1.5.29 and JSchema 0.46.0
d51cb4a
Use IAnalyzeOptions.Quiet in SarifCli.FunctionalTests
e6f6029
Add a comment.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this naming convention different? Should be SarifCli.FunctionalTests.dll. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
In reply to: 76704201 [](ancestors = 76704201)