Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Update CosmosDB Memory Connector to new Text Search Design #6835

Closed
alliscode opened this issue Jun 19, 2024 · 1 comment · Fixed by #9698
Closed

Python: Update CosmosDB Memory Connector to new Text Search Design #6835

alliscode opened this issue Jun 19, 2024 · 1 comment · Fixed by #9698
Assignees
@eavanvalkenburg
Labels
Ignite python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@alliscode
Copy link
Member

Text Search ADR is here: #5799

Implement new abstractions
Unit tests
Integration tests
Document any limitations in the implementation
Implement a basic RAG samples
Work with Sofia on a new Blog post
Obsolete the old implementation
Create task to graduate the Text Search Service
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage and removed triage labels Jun 19, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale Issue is stale because it has been open for 90 days with no activity label Oct 10, 2024
@github-actions github-actions bot removed the stale Issue is stale because it has been open for 90 days with no activity label Oct 11, 2024
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Nov 5, 2024
@eavanvalkenburg eavanvalkenburg moved this to Sprint: Planned in Semantic Kernel Nov 13, 2024
@eavanvalkenburg eavanvalkenburg mentioned this issue Nov 14, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2024
@eavanvalkenburg @moonbox3
Python: Introducing search for CosmosDB NoSQL Collections (#9698)
76052b6 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Adds the search functions for Cosmos DB NoSQL.

Closes #6835 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Adds the search pieces and turns out the upsert cannot work cross
partition key with execute batch, so refactored to using gather(upsert).

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eavanvalkenburg eavanvalkenburg

Labels
Ignite python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python: Introducing search for CosmosDB NoSQL Collections eavanvalkenburg/semantic-kernel
4 participants
@eavanvalkenburg @alliscode @evchaki @markwallace-microsoft