-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Bug: Typo in Default History Summarization prompt: summarizion should be summarization #8545
Comments
markwallace-microsoft
added
.NET
Issue or Pull requests regarding .NET code
triage
labels
Sep 5, 2024
github-actions
bot
changed the title
Bug: Typo in Default History Summarization prompt: summarizion should be summarization
.Net: Bug: Typo in Default History Summarization prompt: summarizion should be summarization
Sep 5, 2024
@jb-ross-bingham - thanks for finding this. Feel free to submit a PR to fix it and we will push it in. |
@evchaki Can I submit a PR for this? I already have a fork created for this. |
4 tasks
@Niladri24dutta you sure can! Thank you. |
@evchaki I have already opened a PR, Can you please let me know if it looks fine? |
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 13, 2024
### Motivation and Context This PR fixes the incorrect spelling of **"summarization"** in `DefaultSummarizationPrompt` of `ChatHistorySummarizationReducer` class ### Description Fixes #8545 ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
There is a minor misspelling of summarization in the default summarization prompt, which is sent to the LLM. Clearly, the LLM understands the prompt, even with the misspelling, but I'm pointing it out in case it helps.
Line in github
....
concise and complete summarizion
... should read ....concise and complete summarization
...To Reproduce
Steps to reproduce the behavior:
I apologize if this isn't technically a bug. There are no steps to reproduce, the misspelling is in the source code, linked above.
Expected behavior
(no expected behavior)
Screenshots
(no screenshots)
Platform
N/A
Additional context
Apologies if this wasted someone's time. Just pointing it out in case it helps.
The text was updated successfully, but these errors were encountered: