Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Graduate Filters feature #9499

Closed
4 tasks done
markwallace-microsoft opened this issue Nov 1, 2024 · 0 comments · Fixed by #9774
Closed
4 tasks done

.Net: Graduate Filters feature #9499

markwallace-microsoft opened this issue Nov 1, 2024 · 0 comments · Fixed by #9774
Assignees
@dmytrostruk
Labels
feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Nov 1, 2024 •
edited by dmytrostruk
Loading

  • Remove Kernel events
  • Remove Filters V1
  • Create migration guides for Kernel events and Filters v1
  • Remove Experimental flag in remaining places in code and documentation
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code feature_graduation Applied to all feature graduation issues Ignite labels Nov 1, 2024
@github-actions github-actions bot changed the title Graduate Filters feature .Net: Graduate Filters feature Nov 1, 2024
@markwallace-microsoft markwallace-microsoft added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed triage labels Nov 1, 2024
@markwallace-microsoft markwallace-microsoft moved this from Backlog to Sprint: Planned in Semantic Kernel Nov 4, 2024
@dmytrostruk dmytrostruk removed the Ignite label Nov 6, 2024
@dmytrostruk dmytrostruk mentioned this issue Nov 19, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 19, 2024
@dmytrostruk
.Net: Removed Kernel events (#9748)
e6413c3 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Related: #9499

Removed the usage of obsolete Kernel Events in favor of Filters as part
of Filters graduation process.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@dmytrostruk dmytrostruk mentioned this issue Nov 20, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 21, 2024
@dmytrostruk
.Net: Removed experimental flags in Filters (#9774)
d8acb75 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Closes: #9499

1. Removed `Experimental` flag from `AutoFunctionInvocationFilter`
classes and properties.
2. Removed `Experimental` flag from `IsStreaming` boolean property in
filter context models.
3. Added a unit test to verify function sequence index property
behavior.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@github-project-automation github-project-automation bot moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmytrostruk dmytrostruk

Labels
feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: Removed experimental flags in Filters dmytrostruk/semantic-kernel
2 participants
@dmytrostruk @markwallace-microsoft