Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Bug: .Net Processes sometimes fail due cancellation token getting triggered twice when it was already disposed #9837

Closed
esttenorio opened this issue Nov 27, 2024 · 0 comments · Fixed by #9811
Closed

.Net: Bug: .Net Processes sometimes fail due cancellation token getting triggered twice when it was already disposed #9837

esttenorio opened this issue Nov 27, 2024 · 0 comments · Fixed by #9811
Assignees
@esttenorio
Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code processes sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@esttenorio
Copy link
Contributor

No description provided.

@esttenorio esttenorio added .NET Issue or Pull requests regarding .NET code bug Something isn't working processes labels Nov 27, 2024
@esttenorio esttenorio self-assigned this Nov 27, 2024
@github-actions github-actions bot changed the title Bug: .Net Processes sometimes fail due cancellation token getting triggered twice when it was already disposed .Net: Bug: .Net Processes sometimes fail due cancellation token getting triggered twice when it was already disposed Nov 27, 2024
@esttenorio esttenorio mentioned this issue Nov 27, 2024
Merged
4 tasks
@markwallace-microsoft markwallace-microsoft added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed triage labels Nov 27, 2024
@crickman crickman moved this to Bug in Semantic Kernel Dec 3, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2024
@esttenorio @estenori
.Net Processes - Refactoring/expanding Process Sample02 (#9811)
3c13912 
### Description

- Updating Sample 02 to expand the usage and show case how to refactor
the same process by using subprocesses as steps.
- Improving README file with more details on this sample
- Add more unit tests for Process testing/improving comments

Fixes #9836 
Fixes #9837 

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Estefania Tenorio <estenori@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esttenorio esttenorio

Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code processes sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net Processes - Refactoring/expanding Process Sample02 esttenorio/semantic-kernel
2 participants
@esttenorio @markwallace-microsoft