Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Add support for agents loading from declarative agent manifests #9848

Closed
baywet opened this issue Nov 29, 2024 · 2 comments · Fixed by #9849
Closed

.Net: Add support for agents loading from declarative agent manifests #9848

baywet opened this issue Nov 29, 2024 · 2 comments · Fixed by #9849
Assignees
Labels
agents enhancement .NET Issue or Pull requests regarding .NET code

Comments

@baywet
Copy link
Member

baywet commented Nov 29, 2024

Similar to #9436

From looking at this example

https://github.com/microsoft/Agents-for-net/blob/main/src/samples/SemanticKernel/WeatherBot/Agents/WeatherForecastAgent.cs

We'll want to be able to load an agent from a declarative agent manifest.

Parsing capability is located in this file from Microsoft.Plugins.Manifest library.

https://github.com/microsoft/Microsoft.Plugins.Manifest/blob/main/src/PluginsManifest/DcSchema/DcManifestDocument.cs

I'm happy to do this work, you can go ahead and assign it to me.

@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Nov 29, 2024
@github-actions github-actions bot changed the title Add support for agents loading from declarative agent manifests .Net: Add support for agents loading from declarative agent manifests Nov 29, 2024
@baywet
Copy link
Member Author

baywet commented Nov 29, 2024

Here are a set of DAs samples
https://github.com/pnp/copilot-pro-dev-samples/blob/main/samples/
https://github.com/gim-home/declarative-agent-samples/tree/main/samples (internal)

Some additional notes: capabilities should NOT be imported at this time, as they rely on first party infrastructure.
We should automatically import the associated CAPs if we can find the target path.

@crickman
Copy link
Contributor

crickman commented Dec 2, 2024

@baywet - Thank you for identifying this improvement and sharing the broader context.

@crickman crickman moved this from Backlog to Sprint: In Progress in Semantic Kernel Dec 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 6, 2024
fixes #9848
This is a draft PR, at this point it's not ready for a full review.
I'd like feedback on the location of the new extension method, and on
the fact that I had to add a reference to the agents project.
Here is the rationale for placing it here: it needs access to the
copilot agent plugins extension method and a few other types.
Here is the rationale for adding the reference to the agents project: it
needs access to the kernel agent type.

---------

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents enhancement .NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants