Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copilot chat cleanup - removing Vite and updating README #284

Merged

Conversation

teresaqhoang
Copy link
Contributor

Motivation and Context

Removing Vite dependency to simplify toolchain + updating README

Description

We are authenticating with the /common endpoint, and in order to use /common/ endpoint, the application must not be configured with 'Consumer' as the user audience. The userAudience should be configured with 'All' to use /common/ endpoint.

Contribution Checklist

@teresaqhoang teresaqhoang changed the base branch from feature-multimod to feature-refapp April 3, 2023 17:06
@adrianwyatt adrianwyatt added the PR: ready for review All feedback addressed, ready for reviews label Apr 3, 2023
@adrianwyatt adrianwyatt self-assigned this Apr 3, 2023
@teresaqhoang
Copy link
Contributor Author

@adrianwyatt waiting on for a feature description for Shannon to update README (but non-blocking, we can update it in a later PR)

@teresaqhoang teresaqhoang marked this pull request as ready for review April 3, 2023 17:51
@teresaqhoang teresaqhoang added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: ready for review All feedback addressed, ready for reviews labels Apr 3, 2023
@adrianwyatt adrianwyatt merged commit 0c917a7 into microsoft:feature-refapp Apr 3, 2023
@teresaqhoang teresaqhoang deleted the copilot-chat-cleanup branch April 3, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants