Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Skills NuGet Packages #5

Merged
merged 17 commits into from
Mar 1, 2023
Merged

Refactoring Skills NuGet Packages #5

merged 17 commits into from
Mar 1, 2023

Conversation

shawncal
Copy link
Member

@shawncal shawncal commented Mar 1, 2023

Motivation and Context

Currently, a user must acquire both the Microsoft.SemanticKernel.Skills package and, for most skills, a separate Microsoft.SemanticKernel.Connectors.* package. It's not clear that this is needed, nor is it clear what Connector you'd need.

Description

Changes:

  • Microsoft.SemanticKernel.Connectors.* packages are all changed to the Microsoft.SemanticKernel.Skills.* namespace for increased discoverability
  • Each connector is packaged under its skill namespace, i.e.
    • Microsoft.SemanticKernel.Connectors.Bing becomes Microsoft.SemanticKernel.Skills.Web

Contribution Checklist

@shawncal shawncal added the PR: ready for review All feedback addressed, ready for reviews label Mar 1, 2023
@dluc dluc added PR: feedback to address Waiting for PR owner to address comments/questions and removed PR: ready for review All feedback addressed, ready for reviews labels Mar 1, 2023
@shawncal shawncal added PR: ready for review All feedback addressed, ready for reviews and removed PR: feedback to address Waiting for PR owner to address comments/questions labels Mar 1, 2023
Copy link
Contributor

@dluc dluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages tested, looking also at the nested dependencies. LGTM

Copy link
Member

@lemillermicrosoft lemillermicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dluc dluc merged commit 36fbded into microsoft:main Mar 1, 2023
@dluc dluc deleted the skills-nugets branch March 1, 2023 04:43
adrianwyatt added a commit that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants