-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Skills NuGet Packages #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samples/dotnet/api-azure-function/SemanticKernelFunction.csproj
Outdated
Show resolved
Hide resolved
dluc
added
PR: feedback to address
Waiting for PR owner to address comments/questions
and removed
PR: ready for review
All feedback addressed, ready for reviews
labels
Mar 1, 2023
shawncal
added
PR: ready for review
All feedback addressed, ready for reviews
and removed
PR: feedback to address
Waiting for PR owner to address comments/questions
labels
Mar 1, 2023
dluc
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages tested, looking also at the nested dependencies. LGTM
lemillermicrosoft
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, a user must acquire both the Microsoft.SemanticKernel.Skills package and, for most skills, a separate Microsoft.SemanticKernel.Connectors.* package. It's not clear that this is needed, nor is it clear what Connector you'd need.
Description
Changes:
Microsoft.SemanticKernel.Connectors.*
packages are all changed to theMicrosoft.SemanticKernel.Skills.*
namespace for increased discoverabilityMicrosoft.SemanticKernel.Connectors.Bing
becomesMicrosoft.SemanticKernel.Skills.Web
Contribution Checklist
dotnet format