Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: small fix for CH serialization #5738

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Python: small fix for CH serialization #5738

merged 2 commits into from
Apr 2, 2024

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Noticed a small issue when ChatHistory is created with different types of messages, and then serialized.
This fixed that and adds a test for that case.

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg marked this pull request as ready for review April 2, 2024 19:50
@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner April 2, 2024 19:50
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Apr 2, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Apr 2, 2024 •
edited
Loading

Py3.8 Test Coverage

Python 3.8 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/ai/open_ai/contents
   open_ai_chat_message_content.py34682%40, 44, 46–47, 53, 61
semantic_kernel/contents
   chat_history.py129894%259–260, 290–292, 305–307
TOTAL5557102082% 

Python 3.8 Unit Test Overview

Tests Skipped Failures Errors Time
1207 11 💤 0 ❌ 0 🔥 19.422s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 2, 2024
@eavanvalkenburg eavanvalkenburg removed this pull request from the merge queue due to a manual request Apr 2, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 2, 2024
Merged via the queue into microsoft:main with commit 290f44d Apr 2, 2024
30 checks passed
@eavanvalkenburg eavanvalkenburg deleted the fix_test_chat_history branch April 2, 2024 20:28
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
@eavanvalkenburg
Python: small fix for CH serialization (microsoft#5738)
20304f3 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Noticed a small issue when ChatHistory is created with different types
of messages, and then serialized.
This fixed that and adds a test for that case.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonbox3 moonbox3 moonbox3 approved these changes

@juliomenendez juliomenendez juliomenendez approved these changes

Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eavanvalkenburg @markwallace-microsoft @juliomenendez @moonbox3